You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/12/15 11:17:00 UTC
[GitHub] [camel-k] johnpoth opened a new pull request #2835: Local dependencies
johnpoth opened a new pull request #2835:
URL: https://github.com/apache/camel-k/pull/2835
<!-- Description -->
Requires https://github.com/container-tools/spectrum/pull/7 and a few enhancements but the core is here :)
Thanks !
<!--
Enter your extended release note in the below block. If the PR requires
additional action from users switching to the new release, include the string
"action required". If no release note is required, write "NONE".
You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" to make sure
the text is added to the right section of the release notes.
-->
**Release Note**
```release-note
NONE
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] johnpoth commented on pull request #2835: Local dependencies
Posted by GitBox <gi...@apache.org>.
johnpoth commented on pull request #2835:
URL: https://github.com/apache/camel-k/pull/2835#issuecomment-1032545963
Ok I think it's ready to be reviewed! The test failure seem unrelated. Feel free to comment on the [wagon](https://github.com/johnpoth/wagon-docker-registry) behavior as well if needed. To be compliant with various Registry vendors, we map Maven artifacts to Image names by: lower casing it's HTTP path, prefixed with `maven_`, `.` and `/` are replaced with `_` so for example:
| Maven artifact | Maven HTTP path | Image Name | Image Tag
| ------------- | ------------- | ------------- | ------------- |
| `org.apache.ant:ant:jar:1.10.12` | `org/apache/ant/ant/1.10.12/ant-1.10.12.jar` | `maven_org_apache_ant_ant_1_10_12_ant-1_10_12_jar` | `1.10.12`|
Artifacts stored in the Image Registry that are to be mounted in the running container use the URI: `docker-mvn:groupId:artifactId:extension:version[@mount/path]`. I think I'll add more docs once everything is merged.
Let me know what you think!
Thanks !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] johnpoth commented on pull request #2835: Local dependencies
Posted by GitBox <gi...@apache.org>.
johnpoth commented on pull request #2835:
URL: https://github.com/apache/camel-k/pull/2835#issuecomment-1046691084
cc @astefanutti @oscerd @lburgazzoli
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] johnpoth commented on pull request #2835: Local dependencies
Posted by GitBox <gi...@apache.org>.
johnpoth commented on pull request #2835:
URL: https://github.com/apache/camel-k/pull/2835#issuecomment-1060448315
By the way let me know if I can do anything to help with the review, or if this PR is a bad idea in the first place :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] oscerd commented on a change in pull request #2835: Local dependencies
Posted by GitBox <gi...@apache.org>.
oscerd commented on a change in pull request #2835:
URL: https://github.com/apache/camel-k/pull/2835#discussion_r769532062
##########
File path: e2e/registry/files/src/main/java/camelk/DeterministicDecryption.java
##########
@@ -0,0 +1,32 @@
+package camelk;
Review comment:
Maybe we need the license here
##########
File path: pkg/cmd/run.go
##########
@@ -18,17 +18,20 @@ limitations under the License.
package cmd
Review comment:
Ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] johnpoth commented on pull request #2835: Local dependencies
Posted by GitBox <gi...@apache.org>.
johnpoth commented on pull request #2835:
URL: https://github.com/apache/camel-k/pull/2835#issuecomment-1084283498
rebased from main branch @astefanutti @lburgazzoli
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org