[GitHub] [airflow] dimberman commented on a change in pull request #14461: BugFix: Set correct Pod State in queue after processing status.

[GitBox <gi...@apache.org>]

dimberman commented on a change in pull request #14461:
URL: https://github.com/apache/airflow/pull/14461#discussion_r584870174



##########
File path: airflow/executors/kubernetes_executor.py
##########
@@ -205,7 +205,7 @@ def process_status(
             self.watcher_queue.put((pod_id, namespace, State.FAILED, annotations, resource_version))
         elif status == 'Succeeded':
             self.log.info('Event: %s Succeeded', pod_id)
-            self.watcher_queue.put((pod_id, namespace, None, annotations, resource_version))
+            self.watcher_queue.put((pod_id, namespace, State.SUCCESS, annotations, resource_version))

Review comment:
       @ngaranko @kaxil this doesn't need to be set in the executor. Successes are set by the worker when the task completes. Maybe we should add a comment explaining this?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org