You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by "Xiao Huang (Jira)" <ji...@apache.org> on 2020/10/21 07:48:00 UTC

[jira] [Commented] (FLINK-19395) Replace SqlConversionException with either TableException or ValidationException

    [ https://issues.apache.org/jira/browse/FLINK-19395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17218161#comment-17218161 ] 

Xiao Huang commented on FLINK-19395:
------------------------------------

Hi, [~twalthr]

The PR for this ticket has been created for a while.

Could you help to review it at your convenience ?

Thanks~

> Replace SqlConversionException with either TableException or ValidationException
> --------------------------------------------------------------------------------
>
>                 Key: FLINK-19395
>                 URL: https://issues.apache.org/jira/browse/FLINK-19395
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table SQL / Legacy Planner, Table SQL / Planner
>            Reporter: Timo Walther
>            Assignee: Xiao Huang
>            Priority: Major
>              Labels: pull-request-available, starter
>
> We should avoid creating too many different exceptions without reason. `SqlConversionException` is not necessary and can be replaced by the two commonly used exceptions for TableException or ValidationException. Currently, we throw all three in `SqlToOperation` converters.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)