You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by rxin <gi...@git.apache.org> on 2015/04/26 10:37:24 UTC

[GitHub] spark pull request: [SPARK-7152][SQL] Add a Column expression for ...

GitHub user rxin opened a pull request:

    https://github.com/apache/spark/pull/5705

    [SPARK-7152][SQL] Add a Column expression for partition ID.

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rxin/spark df-pid

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/5705.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5705
    
----
commit 401018f85a51487c11cf602130fabf947236cc7c
Author: Reynold Xin <rx...@databricks.com>
Date:   2015-04-26T08:36:44Z

    [SPARK-7152][SQL] Add a Column expression for partition ID.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-7152][SQL] Add a Column expression for ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/5705#issuecomment-96366127
  
      [Test build #30957 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30957/consoleFull) for   PR 5705 at commit [`401018f`](https://github.com/apache/spark/commit/401018f85a51487c11cf602130fabf947236cc7c).
     * This patch **passes all tests**.
     * This patch merges cleanly.
     * This patch adds no public classes.
     * This patch does not change any dependencies.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-7152][SQL] Add a Column expression for ...

Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5705#discussion_r29107784
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
    @@ -317,18 +331,13 @@ object functions {
       def not(e: Column): Column = !e
     
       /**
    -   * Converts a string expression to upper case.
    +   * Partition ID of the Spark task.
        *
    -   * @group normal_funcs
    -   */
    -  def upper(e: Column): Column = Upper(e.expr)
    --- End diff --
    
    i moved some functions here so they are sorted alphabetically.
     


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-7152][SQL] Add a Column expression for ...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/5705#issuecomment-96350256
  
      [Test build #30957 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/30957/consoleFull) for   PR 5705 at commit [`401018f`](https://github.com/apache/spark/commit/401018f85a51487c11cf602130fabf947236cc7c).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: [SPARK-7152][SQL] Add a Column expression for ...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/spark/pull/5705


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org