[GitHub] [incubator-livy] ajbozarth commented on a change in pull request #249: [LIVY-702]: Submit Spark apps to Kubernetes

[GitBox <gi...@apache.org>]

ajbozarth commented on a change in pull request #249: [LIVY-702]: Submit Spark apps to Kubernetes
URL: https://github.com/apache/incubator-livy/pull/249#discussion_r366602892
 
 

 ##########
 File path: server/src/main/scala/org/apache/livy/server/interactive/InteractiveSession.scala
 ##########
 @@ -402,6 +402,9 @@ class InteractiveSession(
 
       if (livyConf.isRunningOnYarn() || driverProcess.isDefined) {
         Some(SparkApp.create(appTag, appId, driverProcess, livyConf, Some(this)))
+      } else if (livyConf.isRunningOnKubernetes()) {
+        // Create SparkKubernetesApp anyway to recover app monitoring on Livy server restart
+        Some(SparkApp.create(appTag, appId, driverProcess, livyConf, Some(this)))
 
 Review comment:
   If this is just the same line as 404 why is it in it's own `else if` block? Wouldn't it make more sense to add ` || livyConf.isRunningOnKubernetes()` to  the if on line 403?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services