[GitHub] [doris] git-hulk commented on a diff in pull request #18789: fix(be): fix segment fault if the PID_DIR was NOT set

["git-hulk (via GitHub)" <gi...@apache.org>]

git-hulk commented on code in PR #18789:
URL: https://github.com/apache/doris/pull/18789#discussion_r1169890813


##########
be/src/service/doris_main.cpp:
##########
@@ -282,6 +282,10 @@ int main(int argc, char** argv) {
         fprintf(stderr, "you need set DORIS_HOME environment variable.\n");
         exit(-1);
     }
+    if (getenv("PID_DIR") == nullptr) {

Review Comment:
   Sure, is it good to set it as the current dir like the `start_be` script?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org