You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@carbondata.apache.org by xuchuanyin <gi...@git.apache.org> on 2018/07/10 07:37:21 UTC

[GitHub] carbondata pull request #2470: [CARBONDATA-2715][LuceneDataMap] Fix bug in s...

GitHub user xuchuanyin opened a pull request:

    https://github.com/apache/carbondata/pull/2470

    [CARBONDATA-2715][LuceneDataMap] Fix bug in search mode with lucene datamap in windows

    While comparing two pathes, the file separator is different in windows,
    thus causing empty pruned blocklets. This PR will ignore the file
    separator
    
    Be sure to do all of the following checklist to help us incorporate 
    your contribution quickly and easily:
    
     - [ ] Any interfaces changed?
     
     - [ ] Any backward compatibility impacted?
     
     - [ ] Document update required?
    
     - [ ] Testing done
            Please provide details on 
            - Whether new unit test cases have been added or why no new tests are required?
            - How it is tested? Please attach test report.
            - Is it a performance related change? Please attach the performance test report.
            - Any additional information to help reviewers in testing this change.
           
     - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. 
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xuchuanyin/carbondata CARBONDATA-2715_bug_lucene_search_windows

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/carbondata/pull/2470.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2470
    
----
commit 9d77313a795c9a50e38319ab8a385f8e8daada83
Author: xuchuanyin <xu...@...>
Date:   2018-07-10T07:34:26Z

    Fix bug in search mode with lucene datamap in windows
    
    While comparing two pathes, the file separator is different in windows,
    thus causing empty pruned blocklets. This PR will ignore the file
    separator

----


---

[GitHub] carbondata issue #2470: [CARBONDATA-2715][LuceneDataMap] Fix bug in search m...

Posted by ravipesala <gi...@git.apache.org>.

Github user ravipesala commented on the issue:

    https://github.com/apache/carbondata/pull/2470
  
    SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5736/



---

[GitHub] carbondata pull request #2470: [CARBONDATA-2715][LuceneDataMap] Fix bug in s...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/carbondata/pull/2470


---

[GitHub] carbondata issue #2470: [CARBONDATA-2715][LuceneDataMap] Fix bug in search m...

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2470
  
    Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5756/



---

[GitHub] carbondata issue #2470: [CARBONDATA-2715][LuceneDataMap] Fix bug in search m...

Posted by CarbonDataQA <gi...@git.apache.org>.

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/carbondata/pull/2470
  
    Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6976/



---

[GitHub] carbondata issue #2470: [CARBONDATA-2715][LuceneDataMap] Fix bug in search m...

Posted by jackylk <gi...@git.apache.org>.

Github user jackylk commented on the issue:

    https://github.com/apache/carbondata/pull/2470
  
    LGTM


---