You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@kie.apache.org by "tiagobento (via GitHub)" <gi...@apache.org> on 2024/11/05 21:56:54 UTC

[PR] NO-ISSUE: Make examples better reflect their domain and contain more focused code [incubator-kie-tools]

tiagobento opened a new pull request, #2726:
URL: https://github.com/apache/incubator-kie-tools/pull/2726

   In this PR I'm improving almost all examples to have a more descriptive README and package name. I also split the huge `webapp` example to make our builds faster, separating the `serverless-workflow-editor-on-webapp` example be built as part of `partition1.txt`.
   
   I'll update this description describing every change that I made, as well as published URLs for each of the examples.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org

Re: [PR] NO-ISSUE: Make examples better reflect their domain and contain more focused code [incubator-kie-tools]

Posted by "tiagobento (via GitHub)" <gi...@apache.org>.

tiagobento commented on PR #2726:
URL: https://github.com/apache/incubator-kie-tools/pull/2726#issuecomment-2528140898

   @jomarko Thanks! Comments addressed in [bb960bd](https://github.com/apache/incubator-kie-tools/pull/2726/commits/bb960bd7252ba2792a5c6856d1767d309387d21e).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org

Re: [PR] NO-ISSUE: Make examples better reflect their domain and contain more focused code [incubator-kie-tools]

Posted by "jomarko (via GitHub)" <gi...@apache.org>.

jomarko commented on PR #2726:
URL: https://github.com/apache/incubator-kie-tools/pull/2726#issuecomment-2473646698

   ### @kie-tools-examples/bpmn-editor-classic-on-webapp feedback
   All buttons are bound to DMN instead of BPMN
   - **New empty file** tries to create DMN file
   - **Open file** tries to open DMN files
   - **Open Sample** same as ^
   - **Download** downloaded file has dmn extension, not bpmn
   
   opening the homescreen http://localhost:7771/ works


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org

Re: [PR] NO-ISSUE: Make examples better reflect their domain and contain more focused code [incubator-kie-tools]

Posted by "jomarko (via GitHub)" <gi...@apache.org>.

jomarko commented on PR #2726:
URL: https://github.com/apache/incubator-kie-tools/pull/2726#issuecomment-2473724664

   ### @kie-tools-examples/dmn-editor-on-webapp feedback
   🟢 passed
   
   
   #### Code
   `Sidebar.tsx` contains unused import `NavItem`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org

Re: [PR] NO-ISSUE: Make examples better reflect their domain and contain more focused code [incubator-kie-tools]

Posted by "jomarko (via GitHub)" <gi...@apache.org>.

jomarko commented on PR #2726:
URL: https://github.com/apache/incubator-kie-tools/pull/2726#issuecomment-2475503680

   ### @kie-tools-examples/micro-frontends-multiplying-architecture-ping-pong-view-in-react
   same as above ^


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org

Re: [PR] NO-ISSUE: Make examples better reflect their domain and contain more focused code [incubator-kie-tools]

Posted by "jomarko (via GitHub)" <gi...@apache.org>.

jomarko commented on PR #2726:
URL: https://github.com/apache/incubator-kie-tools/pull/2726#issuecomment-2473525184

   - [ ] @kie-tools-examples/bpmn-editor-classic-on-webapp
   - [ ] @kie-tools-examples/dmn-editor-classic-on-webapp
   - [ ] @kie-tools-examples/dmn-editor-on-webapp
   - [ ] @kie-tools-examples/dmn-editor-standalone-on-webapp
   - [ ] @kie-tools-examples/kie-sandbox-commit-message-validation-service
   - [ ] @kie-tools-examples/micro-frontends-multiplying-architecture-base64png-editor
   - [ ] @kie-tools-examples/micro-frontends-multiplying-architecture-base64png-editor-chrome-extension
   - [ ] @kie-tools-examples/micro-frontends-multiplying-architecture-base64png-editor-on-webapp
   - [ ] kie-tools-examples-micro-frontends-multiplying-architecture-base64png-editor-vscode-extension
   - [ ] @kie-tools-examples/micro-frontends-multiplying-architecture-ping-pong-view
   - [ ] @kie-tools-examples/micro-frontends-multiplying-architecture-ping-pong-view-in-angular
   - [ ] @kie-tools-examples/micro-frontends-multiplying-architecture-ping-pong-view-in-react
   - [ ] @kie-tools-examples/micro-frontends-multiplying-architecture-ping-pong-views-on-webapp
   - [ ] @kie-tools-examples/micro-frontends-multiplying-architecture-todo-list-view
   - [ ] @kie-tools-examples/micro-frontends-multiplying-architecture-todo-list-view-on-webapp
   - [ ] kie-tools-examples-micro-frontends-multuplying-architecture-todo-list-view-vscode-extension
   - [ ] @kie-tools-examples/process-compact-architecture
   - [ ] @kie-tools-examples/process-user-tasks-subsystem
   - [ ] @kie-tools-examples/serverless-workflow-editor-standalone-on-webapp
   - [ ] @kie-tools-examples/sonataflow-greeting
   - [ ] @kie-tools-examples/uniforms-patternfly


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org

Re: [PR] NO-ISSUE: Make examples better reflect their domain and contain more focused code [incubator-kie-tools]

Posted by "jomarko (via GitHub)" <gi...@apache.org>.

jomarko commented on PR #2726:
URL: https://github.com/apache/incubator-kie-tools/pull/2726#issuecomment-2475500749

   ### @kie-tools-examples/micro-frontends-multiplying-architecture-ping-pong-view
   No manual checks done, README looks fine.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org

Re: [PR] NO-ISSUE: Make examples better reflect their domain and contain more focused code [incubator-kie-tools]

Posted by "jomarko (via GitHub)" <gi...@apache.org>.

jomarko commented on PR #2726:
URL: https://github.com/apache/incubator-kie-tools/pull/2726#issuecomment-2473832237

   ### @kie-tools-examples/kie-sandbox-commit-message-validation-service
   
   Readme start command should contain the filter


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org

Re: [PR] NO-ISSUE: Make examples better reflect their domain and contain more focused code [incubator-kie-tools]

Posted by "jomarko (via GitHub)" <gi...@apache.org>.

jomarko commented on PR #2726:
URL: https://github.com/apache/incubator-kie-tools/pull/2726#issuecomment-2475603037

   ### @kie-tools-examples/process-compact-architecture
   🔴 I am not able to use `startContainers` script
   
   Getting these exceptions:
   ```
   process-compact-architecture-service  | -------------------------------------------------------
   process-compact-architecture-service  | SQL State  : 42P07
   process-compact-architecture-service  | Error Code : 0
   process-compact-architecture-service  | Message    : ERROR: relation "process_instances" already exists
   process-compact-architecture-service  | Location   : kie-flyway/db/persistence-jdbc/postgresql/V1.35.0__create_runtime_PostgreSQL.sql (/home/jboss/file:/home/jboss/lib/main/org.kie.kie-addons-persistence-jdbc-999-20241016-SNAPSHOT.jar!/kie-flyway/db/persistence-jdbc/postgresql/V1.35.0__create_runtime_PostgreSQL.sql)
   process-compact-architecture-service  | Line       : 21
   process-compact-architecture-service  | Statement  : --
   process-compact-architecture-service  | -- Licensed to the Apache Software Foundation (ASF) under one
   process-compact-architecture-service  | -- or more contributor license agreements.  See the NOTICE file
   process-compact-architecture-service  | -- distributed with this work for additional information
   process-compact-architecture-service  | -- regarding copyright ownership.  The ASF licenses this file
   process-compact-architecture-service  | -- to you under the Apache License, Version 2.0 (the
   process-compact-architecture-service  | -- "License"); you may not use this file except in compliance
   process-compact-architecture-service  | -- with the License.  You may obtain a copy of the License at
   process-compact-architecture-service  | --
   process-compact-architecture-service  | --   http://www.apache.org/licenses/LICENSE-2.0
   process-compact-architecture-service  | --
   process-compact-architecture-service  | -- Unless required by applicable law or agreed to in writing,
   process-compact-architecture-service  | -- software distributed under the License is distributed on an
   process-compact-architecture-service  | -- "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
   process-compact-architecture-service  | -- KIND, either express or implied.  See the License for the
   process-compact-architecture-service  | -- specific language governing permissions and limitations
   process-compact-architecture-service  | -- under the License.
   process-compact-architecture-service  | --
   process-compact-architecture-service  | 
   process-compact-architecture-service  | -- To be used with kie-addons-quarkus-persistence-jdbc for Quarkus or kie-addons-springboot-persistence-jdbc for SpringBoot
   process-compact-architecture-service  | CREATE TABLE process_instances
   process-compact-architecture-service  | (
   process-compact-architecture-service  |     id              character(36)     NOT NULL,
   process-compact-architecture-service  |     payload         bytea             NOT NULL,
   process-compact-architecture-service  |     process_id      character varying NOT NULL,
   process-compact-architecture-service  |     version         bigint,
   process-compact-architecture-service  |     process_version character varying,
   process-compact-architecture-service  |     CONSTRAINT process_instances_pkey PRIMARY KEY (id)
   process-compact-architecture-service  | )
   process-compact-architecture-service  | 
   process-compact-architecture-service  |         at org.flywaydb.core.internal.sqlscript.DefaultSqlScriptExecutor.handleException(DefaultSqlScriptExecutor.java:267)
   process-compact-architecture-service  |         at org.flywaydb.core.internal.sqlscript.DefaultSqlScriptExecutor.executeStatement(DefaultSqlScriptExecutor.java:222)
   process-compact-architecture-service  |         at org.flywaydb.core.internal.sqlscript.DefaultSqlScriptExecutor.execute(DefaultSqlScriptExecutor.java:126)
   process-compact-architecture-service  |         at org.flywaydb.core.internal.resolver.sql.SqlMigrationExecutor.executeOnce(SqlMigrationExecutor.java:68)
   process-compact-architecture-service  |         at org.flywaydb.core.internal.resolver.sql.SqlMigrationExecutor.lambda$execute$0(SqlMigrationExecutor.java:57)
   process-compact-architecture-service  |         at org.flywaydb.core.internal.database.DefaultExecutionStrategy.execute(DefaultExecutionStrategy.java:27)
   process-compact-architecture-service  |         at org.flywaydb.core.internal.resolver.sql.SqlMigrationExecutor.execute(SqlMigrationExecutor.java:56)
   process-compact-architecture-service  |         at org.flywaydb.core.internal.command.DbMigrate.doMigrateGroup(DbMigrate.java:374)
   process-compact-architecture-service  |         ... 36 more
   process-compact-architecture-service  | Caused by: org.postgresql.util.PSQLException: ERROR: relation "process_instances" already exists
   process-compact-architecture-service  |         at org.postgresql.core.v3.QueryExecutorImpl.receiveErrorResponse(QueryExecutorImpl.java:2725)
   process-compact-architecture-service  |         at org.postgresql.core.v3.QueryExecutorImpl.processResults(QueryExecutorImpl.java:2412)
   process-compact-architecture-service  |         at org.postgresql.core.v3.QueryExecutorImpl.execute(QueryExecutorImpl.java:371)
   process-compact-architecture-service  |         at org.postgresql.jdbc.PgStatement.executeInternal(PgStatement.java:502)
   process-compact-architecture-service  |         at org.postgresql.jdbc.PgStatement.execute(PgStatement.java:419)
   process-compact-architecture-service  |         at org.postgresql.jdbc.PgStatement.executeWithFlags(PgStatement.java:341)
   process-compact-architecture-service  |         at org.postgresql.jdbc.PgStatement.executeCachedSql(PgStatement.java:326)
   process-compact-architecture-service  |         at org.postgresql.jdbc.PgStatement.executeWithFlags(PgStatement.java:302)
   process-compact-architecture-service  |         at org.postgresql.jdbc.PgStatement.execute(PgStatement.java:297)
   process-compact-architecture-service  |         at io.agroal.pool.wrapper.StatementWrapper.execute(StatementWrapper.java:220)
   process-compact-architecture-service  |         at org.flywaydb.core.internal.jdbc.JdbcTemplate.executeStatement(JdbcTemplate.java:201)
   process-compact-architecture-service  |         at org.flywaydb.core.internal.sqlscript.ParsedSqlStatement.execute(ParsedSqlStatement.java:95)
   process-compact-architecture-service  |         at org.flywaydb.core.internal.sqlscript.DefaultSqlScriptExecutor.executeStatement(DefaultSqlScriptExecutor.java:210)
   process-compact-architecture-service  |         ... 42 more
   process-compact-architecture-service  | 
   process-compact-architecture-service exited with code 1
   ```
   
   Sounds to me like some additional cleanup of local environment is needed before I start this example, if that is the reason I think we need to share such information in README.
   
   I did:
   - KIE_TOOLS_BUILD__buildExamples=true pnpm -F @kie-tools-examples/process-compact-architecture^... build:dev
   - cd examples/process-compact-architecture
   - mvn clean package -Pcontainer
   - cd docker-compose
   - sh startContainers.sh full
   
   **mvn clean package quarkus:dev** seems to work fine 🟢 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org

Re: [PR] NO-ISSUE: Make examples better reflect their domain and contain more focused code [incubator-kie-tools]

Posted by "jomarko (via GitHub)" <gi...@apache.org>.

jomarko commented on PR #2726:
URL: https://github.com/apache/incubator-kie-tools/pull/2726#issuecomment-2473718287

   ### @kie-tools-examples/dmn-editor-classic-on-webapp feedback
   🟢 passed
   
   
   #### Code
   `Sidebar.tsx` contains unused import `NavItem`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org

Re: [PR] NO-ISSUE: Make examples better reflect their domain and contain more focused code [incubator-kie-tools]

Posted by "jomarko (via GitHub)" <gi...@apache.org>.

jomarko commented on PR #2726:
URL: https://github.com/apache/incubator-kie-tools/pull/2726#issuecomment-2475509261

   ### @kie-tools-examples/micro-frontends-multiplying-architecture-ping-pong-views-on-webapp
   Start command in readme could include `-F` part.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org

Re: [PR] NO-ISSUE: Make examples better reflect their domain and contain more focused code [incubator-kie-tools]

Posted by "tiagobento (via GitHub)" <gi...@apache.org>.

tiagobento commented on PR #2726:
URL: https://github.com/apache/incubator-kie-tools/pull/2726#issuecomment-2524710811

   ### @kie-tools-examples/process-user-tasks-subsystem
   ✅ Removed the test... The example compiles normally now. We currently don't have tests for our examples, but I guess if we want that, we need a new "examples-tests" top-level directory to host them.
   
   ---
   
   ### @kie-tools-examples/micro-frontends-multiplying-architecture-todo-list-view
   ✅ As we discussed, this is ok.
   
   ---
   
   ### @kie-tools-examples/dmn-editor-standalone-on-webapp
   ✅ Took me a while to read the comment, but I finally did:
   
   >  // The paths are important here! Since path2/loan-pre-qualification.dmn is in a
     // different parent path than the main content (path1/can-drive.dmn), it won't be availabe
     // to be used as an included model.
   
   I added a comment to the specific line pointing to the main comment:
    
   `["path2/loan-pre-qualification.dmn", { contentType: "text", content: loadFile("loan-pre-qualification.dmn") }], // Won't be available! Read comment above.`
   
   
   ---
   
   
   Hope it's in good shape now @jomarko. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org

Re: [PR] NO-ISSUE: Make examples better reflect their domain and contain more focused code [incubator-kie-tools]

Posted by "jomarko (via GitHub)" <gi...@apache.org>.

jomarko commented on PR #2726:
URL: https://github.com/apache/incubator-kie-tools/pull/2726#issuecomment-2475700822

   ###  @kie-tools-examples/uniforms-patternfly
   Readme could contain at least information how to build and start the example.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org

Re: [PR] NO-ISSUE: Make examples better reflect their domain and contain more focused code [incubator-kie-tools]

Posted by "jomarko (via GitHub)" <gi...@apache.org>.

jomarko commented on code in PR #2726:
URL: https://github.com/apache/incubator-kie-tools/pull/2726#discussion_r1875796097


##########
examples/micro-frontends-multiplying-architecture-todo-list-view-vscode-extension/README.md:
##########
@@ -31,7 +31,7 @@ This package provides a VS Code Extension containing a 'To do' List View, which
 Before running this example, building its dependencies is required. Run the following command on a Terminal:
 
 ```shell script
-KIE_TOOLS_BUILD__buildExamples=true pnpm -F @kie-tools-examples/micro-frontends-multiplying-architecture-todo-list-view-vscode-extension^... build:dev
+KIE_TOOLS_BUILD__buildExamples=true pnpm -F kie-tools-examples-micro-frontends-multuplying-architecture-todo-list-view-vscode-extension^... build:dev

Review Comment:
   typo here



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org

Re: [PR] NO-ISSUE: Make examples better reflect their domain and contain more focused code [incubator-kie-tools]

Posted by "tiagobento (via GitHub)" <gi...@apache.org>.

tiagobento commented on PR #2726:
URL: https://github.com/apache/incubator-kie-tools/pull/2726#issuecomment-2489736784

   General comments:
   - All commands in READMEs assume you're in the example's folder.
   - Bootstrapping the repo with `pnpm bootstrap` is always necessary.
   
   #### @kie-tools-examples/dmn-editor-classic-on-webapp
   ✅ Fixed
   
   ---
   
   #### @kie-tools-examples/dmn-editor-on-webapp
   ✅ Fixed
   
   ---
   
   #### @kie-tools-examples/dmn-editor-on-webapp
   ✅ Fixed
   
   ---
   
   #### @kie-tools-examples/dmn-editor-standalone-on-webapp
   🟡 Updated the port. Will investigate the failures.
   
   ---
   
   #### @kie-tools-examples/kie-sandbox-commit-message-validation-service
   ✅ There are no build instructions necessary here.. Simply "pnpm start" suffices. 
   
   ---
   
   #### @kie-tools-examples/micro-frontends-multiplying-architecture-base64png-editor
   ✅ True. This is not runnable. Mentioned in the README.
   
   ---
   
   #### @kie-tools-examples/micro-frontends-multiplying-architecture-base64png-editor-chrome-extension
   ✅ There are some in this repo! :) Or you can use the Base64 Editor VS Code Extension to create some based on PNG files.
   
   ---
   
   #### @kie-tools-examples/micro-frontends-multiplying-architecture-base64png-editor-on-webapp
   ✅ Nothing done.
   
   
   ---
   
   #### kie-tools-examples-micro-frontends-multiplying-architecture-base64png-editor-vscode-extension
   ✅ Not having the scope (`@kie-tools`) part in the name of the package is a requirement from the VS Code Marketplace. Fixed the build command. Build failed for you because you didn't bootstrap first, I guess?
   
   ---
   
   #### @kie-tools-examples/micro-frontends-multiplying-architecture-ping-pong-view
   ✅ OK
   
   ---
   
   #### @kie-tools-examples/micro-frontends-multiplying-architecture-ping-pong-view-in-angular
   ✅ This is not runnable. I made it clear on the README now.
   
   ---
   
   #### @kie-tools-examples/micro-frontends-multiplying-architecture-ping-pong-view-in-react
   ✅ Same as above.
   
   ---
   
   #### @kie-tools-examples/micro-frontends-multiplying-architecture-ping-pong-views-on-webapp
   ✅ OK
   
   ---
   
   #### @kie-tools-examples/micro-frontends-multiplying-architecture-todo-list-view
   🟡 Not sure I understand your feedback here...
   
   ---
   
   #### @kie-tools-examples/micro-frontends-multiplying-architecture-todo-list-view-on-webapp
   ✅ OK
   
   ----
   
   #### kie-tools-examples-micro-frontends-multuplying-architecture-todo-list-view-vscode-extension
   ✅ Please see the other VS Code extension example's comment from my end as they apply here too.
   
   ---
   
   #### @kie-tools-examples/process-compact-architecture
   ✅ True... this is expected, and we need to upgrade the Kogito version of the repo. I'll do it soon in a separate PR.
   
   ---
   
   #### @kie-tools-examples/process-user-tasks-subsystem
   🟡 Weird... Will investigate. Thanks!
   
   --- 
   
   ####  @kie-tools-examples/serverless-workflow-editor-standalone-on-webapp
   ✅ OK
   
   ---
   
   #### @kie-tools-examples/sonataflow-greeting
   ✅ Out of scope of this PR.
   
   ----
   
   ### @kie-tools-examples/uniforms-patternfly
   ✅ Out of scope of this PR.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org

Re: [PR] NO-ISSUE: Make examples better reflect their domain and contain more focused code [incubator-kie-tools]

Posted by "jomarko (via GitHub)" <gi...@apache.org>.

jomarko commented on PR #2726:
URL: https://github.com/apache/incubator-kie-tools/pull/2726#issuecomment-2473907612

   ### @kie-tools-examples/micro-frontends-multiplying-architecture-base64png-editor-chrome-extension
   
   Start command misses filter.
   
   No manual check done. Do you have a link for a public base64png file on github that I could try for verification?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org

Re: [PR] NO-ISSUE: Make examples better reflect their domain and contain more focused code [incubator-kie-tools]

Posted by "jomarko (via GitHub)" <gi...@apache.org>.

jomarko commented on PR #2726:
URL: https://github.com/apache/incubator-kie-tools/pull/2726#issuecomment-2475648440

   ### @kie-tools-examples/serverless-workflow-editor-standalone-on-webapp
   Manual check passed, start command could maybe include `-F` part.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org

Re: [PR] NO-ISSUE: Make examples better reflect their domain and contain more focused code [incubator-kie-tools]

Posted by "jomarko (via GitHub)" <gi...@apache.org>.

jomarko commented on PR #2726:
URL: https://github.com/apache/incubator-kie-tools/pull/2726#issuecomment-2475494655

   ### kie-tools-examples-micro-frontends-multiplying-architecture-base64png-editor-vscode-extension
   is not consistent in naming:
   - `kie-tools-examples-micro-frontends-multiplying-architecture-base64png-editor-vscode-extension`
   - vs `@kie-tools-examples/micro-frontends-multiplying-architecture-base64png-editor-vscode-extension`, 
   
   this is also incompatible with the build command [1] `KIE_TOOLS_BUILD__buildExamples=true pnpm -F @kie-tools-examples/micro-frontends-multiplying-architecture-base64png-editor-vscode-extension^... build:dev`
   
   Probably also `build:prod` command should contain `-F` part.
   
   🔴  build command [1] failed 
   ```
   │ > copyfiles -u 1 "src/**/*.{sass,scss,css}" dist/
   └─ Running...
   packages/vscode-extension build:dev$ rimraf dist && tsc -p tsconfig.json
   │ src/workspace/VsCodeResourceContentServiceForWorkspaces.ts(33,27): error TS2307: Cannot find module 'isomorphic-git' or its corresponding type declarations.
   │ src/workspace/VsCodeResourceContentServiceForWorkspaces.ts(81,10): error TS7006: Parameter 'p' implicitly has an 'any' type.
   └─ Failed in 9.5s at /home/jomarko/kie-tools/packages/vscode-extension
   /home/jomarko/kie-tools/packages/vscode-extension:
    ERR_PNPM_RECURSIVE_RUN_FIRST_FAIL  @kie-tools-core/vscode-extension@0.0.0 build:dev: `rimraf dist && tsc -p tsconfig.json`
   Exit status 2
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org

Re: [PR] NO-ISSUE: Make examples better reflect their domain and contain more focused code [incubator-kie-tools]

Posted by "jomarko (via GitHub)" <gi...@apache.org>.

jomarko commented on PR #2726:
URL: https://github.com/apache/incubator-kie-tools/pull/2726#issuecomment-2475527949

   ### kie-tools-examples-micro-frontends-multuplying-architecture-todo-list-view-vscode-extension
   Similar issues as base64png vscode extension package
   
   ```
   │ [run-script-if] Finished 'pnpm build'
   └─ Done in 9s
   packages/editor build:dev$ rimraf dist && pnpm copy:css && tsc -p tsconfig.json
   │ > @kie-tools-core/editor@0.0.0 copy:css /home/jomarko/kie-tools/packages/editor
   │ > copyfiles -u 1 "src/**/*.{sass,scss,css}" dist/
   └─ Done in 9.2s
   packages/vscode-extension build:dev$ rimraf dist && tsc -p tsconfig.json
   │ src/workspace/VsCodeResourceContentServiceForWorkspaces.ts(33,27): error TS2307: Cannot find module 'isomorphic-git' or its corresponding type declarations.
   │ src/workspace/VsCodeResourceContentServiceForWorkspaces.ts(81,10): error TS7006: Parameter 'p' implicitly has an 'any' type.
   └─ Failed in 6.1s at /home/jomarko/kie-tools/packages/vscode-extension
   /home/jomarko/kie-tools/packages/vscode-extension:
    ERR_PNPM_RECURSIVE_RUN_FIRST_FAIL  @kie-tools-core/vscode-extension@0.0.0 build:dev: `rimraf dist && tsc -p tsconfig.json`
   Exit status 2
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org

Re: [PR] NO-ISSUE: Make examples better reflect their domain and contain more focused code [incubator-kie-tools]

Posted by "ljmotta (via GitHub)" <gi...@apache.org>.

ljmotta merged PR #2726:
URL: https://github.com/apache/incubator-kie-tools/pull/2726


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org

Re: [PR] NO-ISSUE: Make examples better reflect their domain and contain more focused code [incubator-kie-tools]

Posted by "jomarko (via GitHub)" <gi...@apache.org>.

jomarko commented on PR #2726:
URL: https://github.com/apache/incubator-kie-tools/pull/2726#issuecomment-2473843071

   ### @kie-tools-examples/micro-frontends-multiplying-architecture-base64png-editor
   Readme build and start command is missing


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org

Re: [PR] NO-ISSUE: Make examples better reflect their domain and contain more focused code [incubator-kie-tools]

Posted by "jomarko (via GitHub)" <gi...@apache.org>.

jomarko commented on PR #2726:
URL: https://github.com/apache/incubator-kie-tools/pull/2726#issuecomment-2475502259

   ### @kie-tools-examples/micro-frontends-multiplying-architecture-ping-pong-view-in-angular
   No manual checks done. From README it is not clear to me how to start the example.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org

Re: [PR] NO-ISSUE: Make examples better reflect their domain and contain more focused code [incubator-kie-tools]

Posted by "jomarko (via GitHub)" <gi...@apache.org>.

jomarko commented on PR #2726:
URL: https://github.com/apache/incubator-kie-tools/pull/2726#issuecomment-2475482819

   ### @kie-tools-examples/micro-frontends-multiplying-architecture-base64png-editor-on-webapp
   Start command dos not contain filter `-F` part


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org

Re: [PR] NO-ISSUE: Make examples better reflect their domain and contain more focused code [incubator-kie-tools]

Posted by "jomarko (via GitHub)" <gi...@apache.org>.

jomarko commented on PR #2726:
URL: https://github.com/apache/incubator-kie-tools/pull/2726#issuecomment-2475513266

   ### @kie-tools-examples/micro-frontends-multiplying-architecture-todo-list-view
   No checks done, no comments to code.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org

Re: [PR] NO-ISSUE: Make examples better reflect their domain and contain more focused code [incubator-kie-tools]

Posted by "tiagobento (via GitHub)" <gi...@apache.org>.

tiagobento commented on PR #2726:
URL: https://github.com/apache/incubator-kie-tools/pull/2726#issuecomment-2469238391

   @jomarko Sorry not sure if you already began reviewing it, but there's a new commit from @cimbalek here, fixing running the  containers of `process-compact-architecture` example on Ubuntu.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org

Re: [PR] NO-ISSUE: Make examples better reflect their domain and contain more focused code [incubator-kie-tools]

Posted by "jomarko (via GitHub)" <gi...@apache.org>.

jomarko commented on PR #2726:
URL: https://github.com/apache/incubator-kie-tools/pull/2726#issuecomment-2475524095

   ### @kie-tools-examples/micro-frontends-multiplying-architecture-todo-list-view-on-webapp
   Readme start command could include `-F` part probably
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org

Re: [PR] NO-ISSUE: Make examples better reflect their domain and contain more focused code [incubator-kie-tools]

Posted by "jomarko (via GitHub)" <gi...@apache.org>.

jomarko commented on PR #2726:
URL: https://github.com/apache/incubator-kie-tools/pull/2726#issuecomment-2475609552

   ###  @kie-tools-examples/process-user-tasks-subsystem
   🔴 there is a compilation error
   ```
   [INFO] -------------------------------------------------------------
   [ERROR] COMPILATION ERROR : 
   [INFO] -------------------------------------------------------------
   [ERROR] /home/jomarko/kie-tools/examples/process-user-tasks-subsystem/src/test/java/org/acme/travels/quarkus/ApprovalsProcessTest.java:[28,48] package org.jbpm.process.instance.impl.humantask does not exist
   [ERROR] /home/jomarko/kie-tools/examples/process-user-tasks-subsystem/src/test/java/org/acme/travels/quarkus/ApprovalsProcessTest.java:[29,55] package org.jbpm.process.instance.impl.humantask.phases does not exist
   [ERROR] /home/jomarko/kie-tools/examples/process-user-tasks-subsystem/src/test/java/org/acme/travels/quarkus/ApprovalsProcessTest.java:[30,47] package org.jbpm.process.instance.impl.workitem does not exist
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org

Re: [PR] NO-ISSUE: Make examples better reflect their domain and contain more focused code [incubator-kie-tools]

Posted by "jomarko (via GitHub)" <gi...@apache.org>.

jomarko commented on PR #2726:
URL: https://github.com/apache/incubator-kie-tools/pull/2726#issuecomment-2473799805

   ### @kie-tools-examples/dmn-editor-standalone-on-webapp feedback
   
   
   7778 should be used instead of 9102 in the text below
   ```
   Open http://localhost:9102 to see the list of files bundled by Webpack, then choose an example:
   
   - State Control: http://localhost:9102/state_control.html
   - Read Only: http://localhost:9102/read_only.html
   - With Included Models: http://localhost:9102/with_included_models.html
   ```
   
   next in the code we have this:
   ```
       resources: new Map<string, DmnEditorStandaloneResource>([
         ["path1/can-drive-types.dmn", { contentType: "text", content: loadFile("can-drive-types.dmn") }],
         ["path2/loan-pre-qualification.dmn", { contentType: "text", content: loadFile("loan-pre-qualification.dmn") }],
       ]),
   ```
   
   however in real UI only `can-drive-types` is available.
   |
   ![Screenshot 2024-11-13 153452](https://github.com/user-attachments/assets/3beeb687-4948-445e-8a62-a51e9a609a38)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org

Re: [PR] NO-ISSUE: Make examples better reflect their domain and contain more focused code [incubator-kie-tools]

Posted by "jomarko (via GitHub)" <gi...@apache.org>.

jomarko commented on PR #2726:
URL: https://github.com/apache/incubator-kie-tools/pull/2726#issuecomment-2475667827

   ### @kie-tools-examples/sonataflow-greeting
   No comments


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org

Re: [PR] NO-ISSUE: Make examples better reflect their domain and contain more focused code [incubator-kie-tools]

Posted by "jomarko (via GitHub)" <gi...@apache.org>.

jomarko commented on code in PR #2726:
URL: https://github.com/apache/incubator-kie-tools/pull/2726#discussion_r1875799818


##########
.rat-excludes:
##########
@@ -41,7 +45,7 @@ init.sql
 # examples/micro-frontends-multiplying-architecture-ping-pong-view-in-angular/src/assets/.gitkeep
 .gitkeep
 # examples/sonataflow-greeting-quarkus-example/sonataflow-greeting-quarkus-example.iml
-sonataflow-greeting-quarkus-example.iml
+sonataflow-greeting.iml

Review Comment:
   please update also the comment accordingly, it should be probably:
   `# examples/sonataflow-greeting-quarkus-example/sonataflow-greeting.iml`
   ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org