[GitHub] rob05c edited a comment on issue #2919: url_sig location parameter is not created when a new DS is created with url signing keys

[GitBox <gi...@apache.org>]

rob05c edited a comment on issue #2919: url_sig location parameter is not created when a new DS is created with url signing keys
URL: https://github.com/apache/trafficcontrol/issues/2919#issuecomment-431406888
 
 
   TLDR Go is correctly emulating the Perl API, but the real bug is that the Perl API never did what the Perl UI does.
   
   Looking at the Perl, it looks like it only created the `url_sig` `location` parameter on DS Update, in the UI; not the API, and not on Create.
   
   That said, looking at the other location parameters in Perl, there are a couple of things here:
   1. It looks like there's a mismatch between the UI and API. The Perl UI creates and assigns various location parameters, where the Perl API doesn't create some or all of them. 
   
   2. The other location parameters appear to be created when the `deliveryservice_server` is created (though `url_sig` isn't, which appears to be a bug/oversight). Which makes sense: when the DS is first created, there are no servers assigned, so we can't know which Server Profiles to assign them to.
   
   So, unless there are objections, my plan is to update the Go API to match the Perl UI, and create and assign all location params as necessary, in the `POST+PUT deliveryservice_server` endpoints rather than the `POST deliveryservice`.
   
   That should make the Portal behave the same way the Perl UI does.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services