You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by andorman <gi...@git.apache.org> on 2016/02/16 11:18:08 UTC
[GitHub] cordova-windows pull request: CB-10622 fix targetsize images being...
GitHub user andorman opened a pull request:
https://github.com/apache/cordova-windows/pull/149
CB-10622 fix targetsize images being ignored
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/andorman/cordova-windows master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-windows/pull/149.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #149
----
commit 1073c6e18729a3690b9d152638f0423826b71a3f
Author: Andor Polgari <an...@sap.com>
Date: 2016-02-16T10:13:42Z
CB-10622 fix targetsize images being ignored
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-10622 fix targetsize images being...
Posted by vladimir-kotikov <gi...@git.apache.org>.
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-windows/pull/149#issuecomment-199339254
@limebreaker, this problem has been fixed in https://github.com/apache/cordova-lib/pull/392
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-10622 fix targetsize images being...
Posted by andorman <gi...@git.apache.org>.
Github user andorman commented on the pull request:
https://github.com/apache/cordova-windows/pull/149#issuecomment-184611560
@sgrebnov Sorry for screwing up my previous PR, I opened a new one instead. I hope it's alright this time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-10622 fix targetsize images being...
Posted by vladimir-kotikov <gi...@git.apache.org>.
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-windows/pull/149#issuecomment-189172760
From what i understand the corresponding JIRA contains two separate issues and one of them is a regression (see apache/cordova-lib#392), but second one isn't (the one fixed by this change).
@andorman, what if both `scale` and `targetsize` qualifiers present in image name? Would image then get copied properly?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-10622 fix targetsize images being...
Posted by SunboX <gi...@git.apache.org>.
Github user SunboX commented on the pull request:
https://github.com/apache/cordova-windows/pull/149#issuecomment-196412080
Oh, thanks for the hint! This is great! :smile:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-10622 fix targetsize images being...
Posted by SunboX <gi...@git.apache.org>.
Github user SunboX commented on the pull request:
https://github.com/apache/cordova-windows/pull/149#issuecomment-194349294
You should allow scale 200 images for UWP10 apps. The scale 100 images look a bit blurry on a Lumia 950 and scale 240 is no longer supported:
```js
// Platform default images
var platformImages = [
{dest: 'Square150x150Logo.scale-100.png', width: 150, height: 150},
{dest: 'Square150x150Logo.scale-200.png', width: 300, height: 300},
{dest: 'Square30x30Logo.scale-100.png', width: 30, height: 30},
{dest: 'StoreLogo.scale-100.png', width: 50, height: 50},
{dest: 'SplashScreen.scale-100.png', width: 620, height: 300},
{dest: 'SplashScreen.scale-200.png', width: 1240, height: 600},
// scaled images are specified here for backward compatibility only so we can find them by size
{dest: 'StoreLogo.scale-240.png', width: 120, height: 120},
{dest: 'Square44x44Logo.scale-100.png', width: 44, height: 44},
{dest: 'Square44x44Logo.scale-200.png', width: 88, height: 88},
{dest: 'Square44x44Logo.scale-240.png', width: 106, height: 106},
{dest: 'Square70x70Logo.scale-100.png', width: 70, height: 70},
{dest: 'Square71x71Logo.scale-100.png', width: 71, height: 71},
{dest: 'Square71x71Logo.scale-200.png', width: 142, height: 142},
{dest: 'Square71x71Logo.scale-240.png', width: 170, height: 170},
{dest: 'Square150x150Logo.scale-240.png', width: 360, height: 360},
{dest: 'Square310x310Logo.scale-100.png', width: 310, height: 310},
{dest: 'Square310x310Logo.scale-200.png', width: 620, height: 620},
{dest: 'Wide310x150Logo.scale-100.png', width: 310, height: 150},
{dest: 'Wide310x150Logo.scale-240.png', width: 744, height: 360},
{dest: 'SplashScreenPhone.scale-240.png', width: 1152, height: 1920}
];
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-10622 fix targetsize images being...
Posted by vladimir-kotikov <gi...@git.apache.org>.
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-windows/pull/149#issuecomment-196243570
This is not yet documented, but we're in process of adding docs and examples for `target` attribute
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-10622 fix targetsize images being...
Posted by andorman <gi...@git.apache.org>.
Github user andorman commented on the pull request:
https://github.com/apache/cordova-windows/pull/149#issuecomment-189263000
@vladimir-kotikov The supported image types and namings can be found here:
https://msdn.microsoft.com/en-us/library/windows/apps/mt412102.aspx
Either "scale" or "targetsize" should be provided. Though, I see that "targetsize-*_altform-unplated" images will still be ignored. The regex should be modified to include those as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-10622 fix targetsize images being...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-windows/pull/149
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-10622 fix targetsize images being...
Posted by vladimir-kotikov <gi...@git.apache.org>.
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-windows/pull/149#issuecomment-196243378
@SunboX, for adding icons with scale factors other than `scale-100` and `scale-240` you need to use `target` attribute as following:
```xml
<icon src="res/Windows/Square71x71Logo.png" target="Square71x71Logo.png" />
```
instead of adding separate `<icon ...>` tag for each image
```xml
<icon src="res/Windows/Square71x71Logo.scale-100.png" width="71" height="71" />
<icon src="res/Windows/Square71x71Logo.scale-200.png" width="142" height="142" />
<icon src="res/Windows/Square71x71Logo.scale-240.png" width="170" height="170" />
```
When `target` attribute is specified every image that matches regexp `/Square71x71Logo(\.scale\-\d+)?\.png/` will be copied to application's `images` directory.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-10622 fix targetsize images being...
Posted by limebreaker <gi...@git.apache.org>.
Github user limebreaker commented on the pull request:
https://github.com/apache/cordova-windows/pull/149#issuecomment-198710562
Hello, could it be that the target attr. in:
<icon src="res/windows/storelogo.png" target="StoreLogo" />
is actually completely ignored as I always get no img.target in line 360:
var images = config.getIcons('windows').concat(config.getSplashScreens('windows')); and therefor always "The following image is skipped due to unsupported size".
It seems that the config.getIcons never parses and adds the target attribute. The only way to get it work for me is using width & height attribute. Running win 8.1 cordova 6.0.0 , windows 4.3.1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-10622 fix targetsize images being...
Posted by vladimir-kotikov <gi...@git.apache.org>.
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-windows/pull/149#issuecomment-196797804
The PR with documentation: https://github.com/apache/cordova-docs/pull/558
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-10622 fix targetsize images being...
Posted by nikhilkh <gi...@git.apache.org>.
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-windows/pull/149#issuecomment-185457013
I'm curious - is this a recent regression?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org