[GitHub] [beam] Ardagan commented on a change in pull request #11076: Run precommit portability on java 11

[GitBox <gi...@apache.org>]

Ardagan commented on a change in pull request #11076: Run precommit portability on java 11
URL: https://github.com/apache/beam/pull/11076#discussion_r391111373
 
 

 ##########
 File path: build.gradle
 ##########
 @@ -335,3 +335,27 @@ if (project.hasProperty('javaLinkageArtifactIds')) {
     }
   }
 }
+
+if (project.hasProperty('runWithJava11')) {
+  allprojects {
+    plugins.withId('java') {
+
+      java {
+        sourceCompatibility = JavaVersion.VERSION_1_8
+        targetCompatibility = JavaVersion.VERSION_1_8
+      }
+
+      tasks.withType(JavaCompile) {
+        options.with {
+          fork = true
+          forkOptions.javaHome = java8Home as File
+        }
+      }
+
+      test {
 
 Review comment:
   Will this compile tests with Java11 as well?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services