You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@groovy.apache.org by "paulk-asert (via GitHub)" <gi...@apache.org> on 2026/09/04 05:33:42 UTC

[PR] GROOVY-12350: Handle ?? escapes in SQL InListExpander [groovy]

paulk-asert opened a new pull request, #2875:
URL: https://github.com/apache/groovy/pull/2875

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GROOVY-12350: Handle ?? escapes in SQL InListExpander [groovy]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #2875:
URL: https://github.com/apache/groovy/pull/2875#issuecomment-5536391461

   ## [Codecov](https://app.codecov.io/gh/apache/groovy/pull/2875?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 71.0765%. Comparing base ([`f344d76`](https://app.codecov.io/gh/apache/groovy/commit/f344d76c69477397c8e3ddc25e5a7e7d795a2447?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c860904`](https://app.codecov.io/gh/apache/groovy/commit/c8609047fd7c25481d797f93cf817b8ecb73d1cb?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   [![Impacted file tree graph](https://app.codecov.io/gh/apache/groovy/pull/2875/graphs/tree.svg?width=650&height=150&src=pr&token=1r45138NfQ&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)](https://app.codecov.io/gh/apache/groovy/pull/2875?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   ```diff
   @@                Coverage Diff                 @@
   ##               master      #2875        +/-   ##
   ==================================================
   + Coverage     71.0741%   71.0765%   +0.0023%     
   - Complexity      37300      37303         +3     
   ==================================================
     Files            1578       1578                
     Lines          135384     135388         +4     
     Branches        25084      25085         +1     
   ==================================================
   + Hits            96223      96229         +6     
   + Misses          30477      30475         -2     
     Partials         8684       8684                
   ```
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/groovy/pull/2875?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...y-sql/src/main/java/groovy/sql/InListExpander.java](https://app.codecov.io/gh/apache/groovy/pull/2875?src=pr&el=tree&filepath=subprojects%2Fgroovy-sql%2Fsrc%2Fmain%2Fjava%2Fgroovy%2Fsql%2FInListExpander.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VicHJvamVjdHMvZ3Jvb3Z5LXNxbC9zcmMvbWFpbi9qYXZhL2dyb292eS9zcWwvSW5MaXN0RXhwYW5kZXIuamF2YQ==) | `71.0000% <100.0000%> (+1.2083%)` | :arrow_up: |
   
   ... and [7 files with indirect coverage changes](https://app.codecov.io/gh/apache/groovy/pull/2875/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GROOVY-12350: Handle ?? escapes in SQL InListExpander [groovy]

Posted by "paulk-asert (via GitHub)" <gi...@apache.org>.
paulk-asert merged PR #2875:
URL: https://github.com/apache/groovy/pull/2875


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GROOVY-12350: Handle ?? escapes in SQL InListExpander [groovy]

Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #2875:
URL: https://github.com/apache/groovy/pull/2875#issuecomment-5536400409

   ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.io/dashboard?id=apache_groovy&pullRequest=2875) **Quality Gate passed**  
   Issues  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0 New issues](https://sonarcloud.io/project/issues?id=apache_groovy&pullRequest=2875&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png '') [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_groovy&pullRequest=2875&issueStatuses=ACCEPTED)
   
   Measures  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_groovy&pullRequest=2875&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [100.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_groovy&pullRequest=2875&metric=new_coverage&view=list)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_groovy&pullRequest=2875&metric=new_duplicated_lines_density&view=list)  
     
   <!-- sqra-placement-anchor -->
   [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_groovy&pullRequest=2875)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GROOVY-12350: Handle ?? escapes in SQL InListExpander [groovy]

Posted by "testlens-app[bot] (via GitHub)" <gi...@apache.org>.
testlens-app[bot] commented on PR #2875:
URL: https://github.com/apache/groovy/pull/2875#issuecomment-5536348501

   ## 🚨 TestLens detected 1 failed test 🚨
   
   Here is what you can do:
   
   1) Inspect the test failures carefully.
   2) If you are convinced that some of the tests are flaky, you can mute them below.
   3) Finally, trigger a rerun by checking the rerun checkbox.
   
   ### Test Summary
   
   #### [Build and test / lts \(17, macos-latest\)](https://github.com/apache/groovy/actions/runs/33840946966/job/100922942766?pr=2875) > :test
   
   | Test | Runs | Flakiness |
   |---|---|--:|
   | ChannelSelectTest > testDataBeatsTheTimerAndTheTimerStillFires\(\) | ❌ | 11%&nbsp;🔴 |
   
   🏷️ Commit: c8609047fd7c25481d797f93cf817b8ecb73d1cb
   ▶️ Tests:  56379 executed
   🟡 Checks: 7/29 completed
   
   ### Test Failures
   
   <details><summary><strong>ChannelSelectTest > testDataBeatsTheTimerAndTheTimerStillFires()</strong> (:test in <a href="https://github.com/apache/groovy/actions/runs/33840946966/job/100922942766?pr=2875">Build and test / lts (17, macos-latest)</a>)</summary>
   
   ```
   Assertion failed: 
   
   assert result.index == 0 && result.value == 'done'
          |      |     |    |
          |      1     |    false
          |            false
          SelectResult[channel=1, value=2026-09-04T05:55:18.832128Z]
   
   	at org.codehaus.groovy.runtime.InvokerHelper.createAssertError(InvokerHelper.java:409)
   	at TestScript67.run(TestScript67.groovy:12)
   	at groovy.lang.GroovyShell.evaluate(GroovyShell.java:552)
   	at groovy.lang.GroovyShell.evaluate(GroovyShell.java:587)
   	at groovy.lang.GroovyShell.evaluate(GroovyShell.java:571)
   	at groovy.test.GroovyAssert.assertScript(GroovyAssert.java:106)
   	at groovy.test.GroovyAssert.assertScript(GroovyAssert.java:96)
   	at groovy.concurrent.ChannelSelectTest.testDataBeatsTheTimerAndTheTimerStillFires(ChannelSelectTest.groovy:1134)
   ```
   
   </details>
   
   ### Rerun Controls
   > [!NOTE]
   > Checks are currently running using the configuration below.
   
   Select tests to mute in this pull request:
   
   🔲 ChannelSelectTest > testDataBeatsTheTimerAndTheTimerStillFires\(\) <!-- uniqueId=[engine:junit-jupiter]/[class:groovy.concurrent.ChannelSelectTest]/[method:testDataBeatsTheTimerAndTheTimerStillFires()] -->
   
   Reuse successful test results:
   
   🔲 ♻️ Only rerun the tests that failed or were muted before
   
   Click the checkbox to trigger a rerun:
   
   🔲 **Rerun jobs**
   
   ---
   _Learn more about TestLens at [testlens.app/docs](https://testlens.app/docs/features/pr-comment/)._
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GROOVY-12350: Handle ?? escapes in SQL InListExpander [groovy]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #2875:
URL: https://github.com/apache/groovy/pull/2875#issuecomment-5536653217

   ### JMH summary — classic (commit `caa8e12`)
   
   Speedup vs trailing 90-day baseline on gh-pages. Higher = faster.
   `1.00` = in line with history. Per-benchmark ratio, geomean within group.
   Time-per-op units inverted so direction is consistent. The *calibrated*
   column divides out this runner's speed vs the baseline hardware, as
   measured by Groovy-independent pure-Java ruler benchmarks.
   
   | Group  | Speedup | Calibrated | n |
   |--------|---------|------------|---|
   | bench | 0.982 × | 0.997 × | 124 |
   | core | 1.160 × | 0.937 × | 108 |
   | grails | 1.253 × | 1.183 × | 80 |
   
   No benchmark is ≥1.5× slower than its 90-day baseline.
   
   > ⚠️ Runner speed differs ≥15% from the historical baseline hardware for: core-ag. Raw speedups are not meaningful for those parts — use the calibrated column.
   
   <sub>Runner calibration (this run vs baseline hardware): bench 0.99× (27 rulers) · core-ag 1.32× (3 rulers) · core-hz 1.11× (3 rulers) · grails-ad 1.06× (3 rulers) · grails-ez 1.06× (3 rulers)</sub>
   
   <sub>Baseline: <code>dev/bench/jmh/&lt;part&gt;/classic/data.js</code> on gh-pages, trailing 90 days. <a href="https://apache.github.io/groovy/dev/bench/jmh/summary.html">Daily dashboard</a> · <a href="https://apache.github.io/groovy/dev/bench/jmh/">Per-suite raw data</a></sub>
   
   <!-- jmh-summary:classic -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GROOVY-12350: Handle ?? escapes in SQL InListExpander [groovy]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #2875:
URL: https://github.com/apache/groovy/pull/2875#issuecomment-5536724326

   ### JMH summary — indy (commit `caa8e12`)
   
   Speedup vs trailing 90-day baseline on gh-pages. Higher = faster.
   `1.00` = in line with history. Per-benchmark ratio, geomean within group.
   Time-per-op units inverted so direction is consistent. The *calibrated*
   column divides out this runner's speed vs the baseline hardware, as
   measured by Groovy-independent pure-Java ruler benchmarks.
   
   | Group  | Speedup | Calibrated | n |
   |--------|---------|------------|---|
   | bench | 1.082 × | 1.117 × | 124 |
   | core | 4.704 × | 4.593 × | 108 |
   | grails | 3.794 × | 3.979 × | 80 |
   
   No benchmark is ≥1.5× slower than its 90-day baseline.
   
   <sub>Runner calibration (this run vs baseline hardware): bench 0.99× (27 rulers) · core-ag 0.99× (3 rulers) · core-hz 1.09× (3 rulers) · grails-ad 0.99× (3 rulers) · grails-ez 0.92× (3 rulers)</sub>
   
   <sub>Baseline: <code>dev/bench/jmh/&lt;part&gt;/indy/data.js</code> on gh-pages, trailing 90 days. <a href="https://apache.github.io/groovy/dev/bench/jmh/summary.html">Daily dashboard</a> · <a href="https://apache.github.io/groovy/dev/bench/jmh/">Per-suite raw data</a></sub>
   
   <!-- jmh-summary:indy -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org