You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by Astralidea <gi...@git.apache.org> on 2016/03/22 05:25:53 UTC
[GitHub] flink pull request: [FLINK-3644] WebRuntimMonitor set java.io.tmpd...
GitHub user Astralidea opened a pull request:
https://github.com/apache/flink/pull/1824
[FLINK-3644] WebRuntimMonitor set java.io.tmpdir does not work
To fix this issue, I think we should add new config to config flink-web temp dir.
I don't know why java.io.tmpdir does not work. it value always /tmp
the space of /tmp in my cluster is very less. user upload often.
So I have to let this config go into effect.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/QunarBlackOps/flink FLINK-3644-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1824.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1824
----
commit 3e581199beff543c3d35e73ab9669fd3907502ad
Author: xueyan.li <xu...@qunar.com>
Date: 2016-03-22T04:20:06Z
add new config for set web monitor tmp dir
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3644] WebRuntimMonitor set java.io.tmpd...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1824
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3644] WebRuntimMonitor set java.io.tmpd...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1824#discussion_r58369425
--- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/HttpRequestHandler.java ---
@@ -70,8 +70,11 @@
/** A decoder factory that always stores POST chunks on disk */
private static final HttpDataFactory DATA_FACTORY = new DefaultHttpDataFactory(true);
- private static final File TMP_DIR = new File(System.getProperty("java.io.tmpdir"));
-
+ private File tmpDir;
--- End diff --
This should be `final`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3644] WebRuntimMonitor set java.io.tmpd...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1824#issuecomment-209046303
Looks good, thank you!
Merging this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3644] WebRuntimMonitor set java.io.tmpd...
Posted by Astralidea <gi...@git.apache.org>.
Github user Astralidea commented on the pull request:
https://github.com/apache/flink/pull/1824#issuecomment-209784384
@StephanEwen
It looks like did not merge into Flink Master?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3644] WebRuntimMonitor set java.io.tmpd...
Posted by Astralidea <gi...@git.apache.org>.
Github user Astralidea commented on the pull request:
https://github.com/apache/flink/pull/1824#issuecomment-205668333
Sorry about commits a lot , I have some trouble in rebase & IDE space problem. This version might be ok.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3644] WebRuntimMonitor set java.io.tmpd...
Posted by Astralidea <gi...@git.apache.org>.
Github user Astralidea commented on the pull request:
https://github.com/apache/flink/pull/1824#issuecomment-199747744
I don't think these change could make yarn failed, could you retest ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3644] WebRuntimMonitor set java.io.tmpd...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1824#issuecomment-209788558
Although Github marks the PR as closed, the change has been merged to the master branch. Because Stephan squashed the commits of the PR into a single commit and rebased the changes the PR is not shown as *committed*. You should find it in the [commit history of the master branch](https://github.com/apache/flink/commits/master).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3644] WebRuntimMonitor set java.io.tmpd...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1824#issuecomment-205282176
This looks quite good. I made two inline comments. After addressing those, this should be good to merge.
Thanks for addressing this issue!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3644] WebRuntimMonitor set java.io.tmpd...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1824#discussion_r58369373
--- Diff: flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java ---
@@ -100,6 +100,11 @@
public static final String JOB_MANAGER_IPC_PORT_KEY = "jobmanager.rpc.port";
/**
+ * The config parameter defining the flink web directory to be used by the webmonitor.
+ */
+ public static final String WEB_MONITOR_DIRECTORY_KEY = "web.monitor.tmpdir";
--- End diff --
This config key should follow the naming scheme of the other web monitor config keys (see `public static final String JOB_MANAGER_WEB_PORT_KEY = "jobmanager.web.port";`), for example `jobmanager.web.tmpdir`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3644] WebRuntimMonitor set java.io.tmpd...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1824#issuecomment-200032560
Hi @Astralidea, thanks for the PR. We are aware of some flaky tests. So there is no need to trigger new builds.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3644] WebRuntimMonitor set java.io.tmpd...
Posted by Astralidea <gi...@git.apache.org>.
Github user Astralidea commented on the pull request:
https://github.com/apache/flink/pull/1824#issuecomment-209852969
@fhueske @StephanEwen Oh, I see. Thanks for the explanation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3644] WebRuntimMonitor set java.io.tmpd...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1824#issuecomment-209852818
It has been merged (in b188637b9016116728f0d16f94e213584b2abfd6), but as Fabian said, I squashed and rebased the commits, to GitHub did not recognize that it was merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---