You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@cxf.apache.org by Benson Margulies <bi...@basistech.com> on 2007/07/17 15:58:20 UTC

Aegis tests and exceptions ...

I note that the source tree contains some careful set up of exceptions
to allow for some testing of exceptions, but no exceptions are tested.
Does this reflect some state of the implementation, or just that no one
has had time to fill in more test cases? I'd volunteer to make tests
that try the exceptions.


Re: Aegis tests and exceptions ...

Posted by Dan Diephouse <da...@envoisolutions.com>.
It seems I missed this part. :-( I should have a commit with it fixed by the
end of the day. Sorry for the troubles!

- Dan

On 7/18/07, Benson Margulies <bi...@basistech.com> wrote:
>
> I gave you a test case on JIRA ... perhaps this is a piece of xfire that
> hasn't migrated yet.
>
> > -----Original Message-----
> > From: Dan Diephouse [mailto:dan@envoisolutions.com]
> > Sent: Wednesday, July 18, 2007 12:17 PM
> > To: cxf-user@incubator.apache.org
> > Subject: Re: Aegis tests and exceptions ...
> >
> > Hi Benson,
> >
> > I'm looking into this. I'll report back as soon as I figure out if a)
> its
> > possible or b) when I have a fix for it :-)
> >
> > - Dan
> >
> > On 7/17/07, Benson Margulies <bi...@basistech.com> wrote:
> > >
> > > Dan,
> > >
> > > Reading the code of 2.0, I see no evidence of any client-side code
> > > capable of taking a soap fault and turning it into a custom
> exception
> > > class. The two interceptors I see (the 1.1 and 1.2 versions) both
> end up
> > > throwing the CXF-specific SoapFault class.
> > >
> > > What am I missing?
> > >
> > > --benson
> > >
> > >
> > > > -----Original Message-----
> > > > From: Dan Diephouse [mailto:dan@envoisolutions.com]
> > > > Sent: Tuesday, July 17, 2007 4:10 PM
> > > > To: cxf-user@incubator.apache.org
> > > > Subject: Re: Aegis tests and exceptions ...
> > > >
> > > > Hi Benson,
> > > >
> > > > More tests are always welcome! Just send along a patch. Cheers,
> > > > - Dan
> > > >
> > > > On 7/17/07, Benson Margulies <bi...@basistech.com> wrote:
> > > > >
> > > > > I note that the source tree contains some careful set up of
> > > exceptions
> > > > > to allow for some testing of exceptions, but no exceptions are
> > > tested.
> > > > > Does this reflect some state of the implementation, or just that
> no
> > > one
> > > > > has had time to fill in more test cases? I'd volunteer to make
> tests
> > > > > that try the exceptions.
> > > > >
> > > > >
> > > >
> > > >
> > > > --
> > > > Dan Diephouse
> > > > Envoi Solutions
> > > > http://envoisolutions.com | http://netzooid.com/blog
> > >
> >
> >
> >
> > --
> > Dan Diephouse
> > Envoi Solutions
> > http://envoisolutions.com | http://netzooid.com/blog
>



-- 
Dan Diephouse
Envoi Solutions
http://envoisolutions.com | http://netzooid.com/blog

RE: Aegis tests and exceptions ...

Posted by Benson Margulies <bi...@basistech.com>.
I gave you a test case on JIRA ... perhaps this is a piece of xfire that
hasn't migrated yet.

> -----Original Message-----
> From: Dan Diephouse [mailto:dan@envoisolutions.com]
> Sent: Wednesday, July 18, 2007 12:17 PM
> To: cxf-user@incubator.apache.org
> Subject: Re: Aegis tests and exceptions ...
> 
> Hi Benson,
> 
> I'm looking into this. I'll report back as soon as I figure out if a)
its
> possible or b) when I have a fix for it :-)
> 
> - Dan
> 
> On 7/17/07, Benson Margulies <bi...@basistech.com> wrote:
> >
> > Dan,
> >
> > Reading the code of 2.0, I see no evidence of any client-side code
> > capable of taking a soap fault and turning it into a custom
exception
> > class. The two interceptors I see (the 1.1 and 1.2 versions) both
end up
> > throwing the CXF-specific SoapFault class.
> >
> > What am I missing?
> >
> > --benson
> >
> >
> > > -----Original Message-----
> > > From: Dan Diephouse [mailto:dan@envoisolutions.com]
> > > Sent: Tuesday, July 17, 2007 4:10 PM
> > > To: cxf-user@incubator.apache.org
> > > Subject: Re: Aegis tests and exceptions ...
> > >
> > > Hi Benson,
> > >
> > > More tests are always welcome! Just send along a patch. Cheers,
> > > - Dan
> > >
> > > On 7/17/07, Benson Margulies <bi...@basistech.com> wrote:
> > > >
> > > > I note that the source tree contains some careful set up of
> > exceptions
> > > > to allow for some testing of exceptions, but no exceptions are
> > tested.
> > > > Does this reflect some state of the implementation, or just that
no
> > one
> > > > has had time to fill in more test cases? I'd volunteer to make
tests
> > > > that try the exceptions.
> > > >
> > > >
> > >
> > >
> > > --
> > > Dan Diephouse
> > > Envoi Solutions
> > > http://envoisolutions.com | http://netzooid.com/blog
> >
> 
> 
> 
> --
> Dan Diephouse
> Envoi Solutions
> http://envoisolutions.com | http://netzooid.com/blog

Re: Aegis tests and exceptions ...

Posted by Dan Diephouse <da...@envoisolutions.com>.
Hi Benson,

I'm looking into this. I'll report back as soon as I figure out if a) its
possible or b) when I have a fix for it :-)

- Dan

On 7/17/07, Benson Margulies <bi...@basistech.com> wrote:
>
> Dan,
>
> Reading the code of 2.0, I see no evidence of any client-side code
> capable of taking a soap fault and turning it into a custom exception
> class. The two interceptors I see (the 1.1 and 1.2 versions) both end up
> throwing the CXF-specific SoapFault class.
>
> What am I missing?
>
> --benson
>
>
> > -----Original Message-----
> > From: Dan Diephouse [mailto:dan@envoisolutions.com]
> > Sent: Tuesday, July 17, 2007 4:10 PM
> > To: cxf-user@incubator.apache.org
> > Subject: Re: Aegis tests and exceptions ...
> >
> > Hi Benson,
> >
> > More tests are always welcome! Just send along a patch. Cheers,
> > - Dan
> >
> > On 7/17/07, Benson Margulies <bi...@basistech.com> wrote:
> > >
> > > I note that the source tree contains some careful set up of
> exceptions
> > > to allow for some testing of exceptions, but no exceptions are
> tested.
> > > Does this reflect some state of the implementation, or just that no
> one
> > > has had time to fill in more test cases? I'd volunteer to make tests
> > > that try the exceptions.
> > >
> > >
> >
> >
> > --
> > Dan Diephouse
> > Envoi Solutions
> > http://envoisolutions.com | http://netzooid.com/blog
>



-- 
Dan Diephouse
Envoi Solutions
http://envoisolutions.com | http://netzooid.com/blog

RE: Aegis tests and exceptions ...

Posted by Benson Margulies <bi...@basistech.com>.
Dan,

Reading the code of 2.0, I see no evidence of any client-side code
capable of taking a soap fault and turning it into a custom exception
class. The two interceptors I see (the 1.1 and 1.2 versions) both end up
throwing the CXF-specific SoapFault class.

What am I missing?

--benson


> -----Original Message-----
> From: Dan Diephouse [mailto:dan@envoisolutions.com]
> Sent: Tuesday, July 17, 2007 4:10 PM
> To: cxf-user@incubator.apache.org
> Subject: Re: Aegis tests and exceptions ...
> 
> Hi Benson,
> 
> More tests are always welcome! Just send along a patch. Cheers,
> - Dan
> 
> On 7/17/07, Benson Margulies <bi...@basistech.com> wrote:
> >
> > I note that the source tree contains some careful set up of
exceptions
> > to allow for some testing of exceptions, but no exceptions are
tested.
> > Does this reflect some state of the implementation, or just that no
one
> > has had time to fill in more test cases? I'd volunteer to make tests
> > that try the exceptions.
> >
> >
> 
> 
> --
> Dan Diephouse
> Envoi Solutions
> http://envoisolutions.com | http://netzooid.com/blog

Re: Aegis tests and exceptions ...

Posted by Dan Diephouse <da...@envoisolutions.com>.
Hi Benson,

More tests are always welcome! Just send along a patch. Cheers,
- Dan

On 7/17/07, Benson Margulies <bi...@basistech.com> wrote:
>
> I note that the source tree contains some careful set up of exceptions
> to allow for some testing of exceptions, but no exceptions are tested.
> Does this reflect some state of the implementation, or just that no one
> has had time to fill in more test cases? I'd volunteer to make tests
> that try the exceptions.
>
>


-- 
Dan Diephouse
Envoi Solutions
http://envoisolutions.com | http://netzooid.com/blog