You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jspwiki.apache.org by "John Volkar (JIRA)" <ji...@apache.org> on 2008/11/10 22:55:44 UTC

[jira] Created: (JSPWIKI-424) Enforce (autofix) baseURL property to end with trailing slash

Enforce (autofix) baseURL property to end with trailing slash
-------------------------------------------------------------

                 Key: JSPWIKI-424
                 URL: https://issues.apache.org/jira/browse/JSPWIKI-424
             Project: JSPWiki
          Issue Type: Improvement
          Components: Core & storage
    Affects Versions: 2.8
         Environment: any
            Reporter: John Volkar
            Priority: Minor
             Fix For: 2.8.1


If baseUrl does not end with a trailing slash CSS is not found causing  the page to be rendered badly.

The installer does not enforce a trailing slash.

When reading the property, if not ending with "/" append one.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (JSPWIKI-424) Enforce (autofix) baseURL property to end with trailing slash

Posted by "Harry Metske (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JSPWIKI-424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Harry Metske closed JSPWIKI-424.
--------------------------------

       Resolution: Fixed
    Fix Version/s:     (was: 2.8.1)
                   3.0
         Assignee: Harry Metske

Fixed in 3.0.0-svn-6

> Enforce (autofix) baseURL property to end with trailing slash
> -------------------------------------------------------------
>
>                 Key: JSPWIKI-424
>                 URL: https://issues.apache.org/jira/browse/JSPWIKI-424
>             Project: JSPWiki
>          Issue Type: Improvement
>          Components: Core & storage
>    Affects Versions: 2.8
>         Environment: any
>            Reporter: John Volkar
>            Assignee: Harry Metske
>            Priority: Minor
>             Fix For: 3.0
>
>
> If baseUrl does not end with a trailing slash CSS is not found causing  the page to be rendered badly.
> The installer does not enforce a trailing slash.
> When reading the property, if not ending with "/" append one.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (JSPWIKI-424) Enforce (autofix) baseURL property to end with trailing slash

Posted by "Kurt Stein (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/JSPWIKI-424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12649355#action_12649355 ] 

Kurt Stein commented on JSPWIKI-424:
------------------------------------

If you are fixing it, would you please add the slash in the DefaultURLConstructor.class. It is missing in the try catch block and generates some funny (web)side-effects.


    public void initialize( WikiEngine engine, 
                            Properties properties )

            catch( MalformedURLException e )
            {
                m_pathPrefix = "/JSPWiki/"; // Just a guess.
            }

> Enforce (autofix) baseURL property to end with trailing slash
> -------------------------------------------------------------
>
>                 Key: JSPWIKI-424
>                 URL: https://issues.apache.org/jira/browse/JSPWIKI-424
>             Project: JSPWiki
>          Issue Type: Improvement
>          Components: Core & storage
>    Affects Versions: 2.8
>         Environment: any
>            Reporter: John Volkar
>            Assignee: Harry Metske
>            Priority: Minor
>             Fix For: 3.0
>
>
> If baseUrl does not end with a trailing slash CSS is not found causing  the page to be rendered badly.
> The installer does not enforce a trailing slash.
> When reading the property, if not ending with "/" append one.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Reopened: (JSPWIKI-424) Enforce (autofix) baseURL property to end with trailing slash

Posted by "Harry Metske (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JSPWIKI-424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Harry Metske reopened JSPWIKI-424:
----------------------------------


I think we need both fixes, so also in the Installer (as Janne mentioned).
I'll have a look this week.

> Enforce (autofix) baseURL property to end with trailing slash
> -------------------------------------------------------------
>
>                 Key: JSPWIKI-424
>                 URL: https://issues.apache.org/jira/browse/JSPWIKI-424
>             Project: JSPWiki
>          Issue Type: Improvement
>          Components: Core & storage
>    Affects Versions: 2.8
>         Environment: any
>            Reporter: John Volkar
>            Assignee: Harry Metske
>            Priority: Minor
>             Fix For: 3.0
>
>
> If baseUrl does not end with a trailing slash CSS is not found causing  the page to be rendered badly.
> The installer does not enforce a trailing slash.
> When reading the property, if not ending with "/" append one.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (JSPWIKI-424) Enforce (autofix) baseURL property to end with trailing slash

Posted by "Harry Metske (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JSPWIKI-424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Harry Metske closed JSPWIKI-424.
--------------------------------

    Resolution: Fixed

Fixed in 3.0.0-svn-12

> Enforce (autofix) baseURL property to end with trailing slash
> -------------------------------------------------------------
>
>                 Key: JSPWIKI-424
>                 URL: https://issues.apache.org/jira/browse/JSPWIKI-424
>             Project: JSPWiki
>          Issue Type: Improvement
>          Components: Core & storage
>    Affects Versions: 2.8
>         Environment: any
>            Reporter: John Volkar
>            Assignee: Harry Metske
>            Priority: Minor
>             Fix For: 3.0
>
>
> If baseUrl does not end with a trailing slash CSS is not found causing  the page to be rendered badly.
> The installer does not enforce a trailing slash.
> When reading the property, if not ending with "/" append one.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.