You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/09/10 10:13:39 UTC
[GitHub] [arrow] revit13 opened a new pull request #8159: "ARROW-9104: [C++] Parquet encryption tests should write files to a temporary directory instead of the testing submodule's directory"
revit13 opened a new pull request #8159:
URL: https://github.com/apache/arrow/pull/8159
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou closed pull request #8159: ARROW-9104: [C++] Parquet encryption tests should write files to a temporary directory instead of the testing submodule's directory
Posted by GitBox <gi...@apache.org>.
pitrou closed pull request #8159:
URL: https://github.com/apache/arrow/pull/8159
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #8159: ARROW-9104: [C++] Parquet encryption tests should write files to a temporary directory instead of the testing submodule's directory
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #8159:
URL: https://github.com/apache/arrow/pull/8159#issuecomment-690253989
@revit13 This is good, thank you!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8159: "ARROW-9104: [C++] Parquet encryption tests should write files to a temporary directory instead of the testing submodule's directory"
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8159:
URL: https://github.com/apache/arrow/pull/8159#issuecomment-690146389
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW
Then could you also rename pull request title in the following format?
ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] revit13 commented on pull request #8159: ARROW-9104: [C++] Parquet encryption tests should write files to a temporary directory instead of the testing submodule's directory
Posted by GitBox <gi...@apache.org>.
revit13 commented on pull request #8159:
URL: https://github.com/apache/arrow/pull/8159#issuecomment-690501845
@pitrou Please ignore my previous comment. It seems that the branch is merged ok. Thanks again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] revit13 commented on pull request #8159: ARROW-9104: [C++] Parquet encryption tests should write files to a temporary directory instead of the testing submodule's directory
Posted by GitBox <gi...@apache.org>.
revit13 commented on pull request #8159:
URL: https://github.com/apache/arrow/pull/8159#issuecomment-690469456
@pitrou Thanks again for the review. I would like to merge the changes but this pull request seems to be closed. I am not sure how to resolve this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] revit13 commented on pull request #8159: "ARROW-9104: [C++] Parquet encryption tests should write files to a temporary directory instead of the testing submodule's directory"
Posted by GitBox <gi...@apache.org>.
revit13 commented on pull request #8159:
URL: https://github.com/apache/arrow/pull/8159#issuecomment-690157916
@pitrou Thanks for your feedback. I changed the code to use TemporaryDir as you suggested. I appreciate it if you could review the new version of the code. (The CI failures so far looks unrelated to the patch)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8159: ARROW-9104: [C++] Parquet encryption tests should write files to a temporary directory instead of the testing submodule's directory
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8159:
URL: https://github.com/apache/arrow/pull/8159#issuecomment-690253470
https://issues.apache.org/jira/browse/ARROW-9104
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] revit13 removed a comment on pull request #8159: ARROW-9104: [C++] Parquet encryption tests should write files to a temporary directory instead of the testing submodule's directory
Posted by GitBox <gi...@apache.org>.
revit13 removed a comment on pull request #8159:
URL: https://github.com/apache/arrow/pull/8159#issuecomment-690469456
@pitrou Thanks again for the review. I would like to merge the changes but this pull request seems to be closed. I am not sure how to resolve this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org