You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-commits@hadoop.apache.org by su...@apache.org on 2019/09/03 07:07:49 UTC

[hadoop] branch trunk updated: HDFS-14630. Configuration.getTimeDurationHelper() should not log time unit warning in info log. Contributed by hemanthboyina.

This is an automated email from the ASF dual-hosted git repository.

surendralilhore pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/hadoop.git


The following commit(s) were added to refs/heads/trunk by this push:
     new 5ff76cb  HDFS-14630. Configuration.getTimeDurationHelper() should not log time unit warning in info log. Contributed by hemanthboyina.
5ff76cb is described below

commit 5ff76cb8bc69d68ba7c9487d00b1dc753d616bb2
Author: Surendra Singh Lilhore <su...@apache.org>
AuthorDate: Tue Sep 3 12:31:23 2019 +0530

    HDFS-14630. Configuration.getTimeDurationHelper() should not log time unit warning in info log. Contributed by hemanthboyina.
---
 .../java/org/apache/hadoop/conf/Configuration.java |  2 --
 .../src/main/resources/hdfs-default.xml            | 23 +++++++++++++++-------
 2 files changed, 16 insertions(+), 9 deletions(-)

diff --git a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
old mode 100644
new mode 100755
index f48641c..180bde2
--- a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
+++ b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
@@ -1885,8 +1885,6 @@ public class Configuration implements Iterable<Map.Entry<String,String>>,
     vStr = StringUtils.toLowerCase(vStr);
     ParsedTimeDuration vUnit = ParsedTimeDuration.unitFor(vStr);
     if (null == vUnit) {
-      logDeprecation("No unit for " + name + "(" + vStr + ") assuming " +
-          defaultUnit);
       vUnit = ParsedTimeDuration.unitFor(defaultUnit);
     } else {
       vStr = vStr.substring(0, vStr.lastIndexOf(vUnit.suffix()));
diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml b/hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
old mode 100644
new mode 100755
index e4e7a15..689cae3
--- a/hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
@@ -756,7 +756,8 @@
   <value>0s</value>
   <description>
     Delay for first block report in seconds. Support multiple time unit
-    suffix(case insensitive), as described in dfs.heartbeat.interval.
+    suffix(case insensitive), as described in dfs.heartbeat.interval.If
+    no time unit is specified then seconds is assumed
   </description>
 </property>
 
@@ -801,7 +802,8 @@
   <description>Interval in seconds for Datanode to scan data directories and
   reconcile the difference between blocks in memory and on the disk.
   Support multiple time unit suffix(case insensitive), as described
-  in dfs.heartbeat.interval.
+  in dfs.heartbeat.interval.If no time unit is specified then seconds
+  is assumed.
   </description>
 </property>
 
@@ -842,6 +844,7 @@
     ms(millis), s(sec), m(min), h(hour), d(day)
     to specify the time (such as 2s, 2m, 1h, etc.).
     Or provide complete number in seconds (such as 30 for 30 seconds).
+    If no time unit is specified then seconds is assumed.
   </description>
 </property>
 
@@ -1051,6 +1054,7 @@
   <description>Namenode periodicity in seconds to check if
     decommission or maintenance is complete. Support multiple time unit
     suffix(case insensitive), as described in dfs.heartbeat.interval.
+    If no time unit is specified then seconds is assumed.
   </description>
 </property>
 
@@ -1181,7 +1185,8 @@
   <description>
     The number of seconds between two periodic checkpoints.
     Support multiple time unit suffix(case insensitive), as described
-    in dfs.heartbeat.interval.
+    in dfs.heartbeat.interval.If no time unit is specified then seconds
+    is assumed.
   </description>
 </property>
 
@@ -1200,7 +1205,8 @@
   <description>The SecondaryNameNode and CheckpointNode will poll the NameNode
   every 'dfs.namenode.checkpoint.check.period' seconds to query the number
   of uncheckpointed transactions. Support multiple time unit suffix(case insensitive),
-  as described in dfs.heartbeat.interval.
+  as described in dfs.heartbeat.interval.If no time unit is specified then
+  seconds is assumed.
   </description>
 </property>
 
@@ -1636,7 +1642,8 @@
     The notification is sent by a datanode when it is being shutdown
     using the shutdownDatanode admin command with the upgrade option.
     Support multiple time unit suffix(case insensitive), as described
-    in dfs.heartbeat.interval.
+    in dfs.heartbeat.interval.If no time unit is specified then seconds
+    is assumed.
   </description>
 </property>
 
@@ -1705,7 +1712,8 @@
     often the logs are rolled. Note that failover triggers a log roll
     so the StandbyNode will be up to date before it becomes active.
     Support multiple time unit suffix(case insensitive), as described
-    in dfs.heartbeat.interval.
+    in dfs.heartbeat.interval.If no time unit is specified then seconds
+    is assumed.
   </description>
 </property>
 
@@ -3413,7 +3421,8 @@
     datanode is not yet registered with the namenode. This wait time
     reduces initial request failures after datanode restart.
     Support multiple time unit suffix(case insensitive), as described
-    in dfs.heartbeat.interval.
+    in dfs.heartbeat.interval.If no time unit is specified then seconds
+    is assumed.
   </description>
 </property>
 


---------------------------------------------------------------------
To unsubscribe, e-mail: common-commits-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-commits-help@hadoop.apache.org