You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by caseyscarborough <gi...@git.apache.org> on 2016/04/24 18:09:50 UTC

[GitHub] commons-lang pull request: Add tests for some missed branches in S...

GitHub user caseyscarborough opened a pull request:

    https://github.com/apache/commons-lang/pull/135

    Add tests for some missed branches in StringUtils

    This pull request adds tests for some missed branches in `StringUtils`.
    
    Tests that the `join` methods (`long[]`, `char[]`, `byte[]`, `int[]`, `float[]`, `double[]`, and `short[]`) return `null` and `EMPTY` when appropriate.
    
    Also tests that `IllegalArgumentException` is properly thrown from `replaceEach` when `searchList` and `replacementList` are different lengths.
    
    Updates line coverage from 99% to 100% in and branch coverage from 97% to 98%.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/caseyscarborough/commons-lang test-missed-branches

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-lang/pull/135.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #135
    
----
commit 602b171c0bada94d1c097bd8d84fd28ecafbd2ab
Author: Casey Scarborough <ca...@gmail.com>
Date:   2016-04-24T15:46:10Z

    Add tests for missed branches in StringUtils

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request: Add tests for some missed branches in S...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/commons-lang/pull/135


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] commons-lang pull request: Add tests for some missed branches in S...

Posted by PascalSchumacher <gi...@git.apache.org>.
Github user PascalSchumacher commented on the pull request:

    https://github.com/apache/commons-lang/pull/135#issuecomment-217714266
  
    Thanks! :+1: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---