You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by neykov <gi...@git.apache.org> on 2015/11/05 21:20:20 UTC
[GitHub] incubator-brooklyn pull request: Disable consistently failing inte...
GitHub user neykov opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/1006
Disable consistently failing integration tests
Disable all integration tests that failed consistently in the last five runs.
Lots more failing tests which succeeded at least once, TBD whether will be fixed or disabled.
Introduce new test group `Broken` which means delete the test or fix it.
The idea behind disabling the tests is to make the integration builds useful, currently they are completely ignored. Hard to notice regressions.
Tried some of the tests locally and they passed, could be an environment issue at least for part of them.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/neykov/incubator-brooklyn disable-integration-tests
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/1006.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1006
----
commit 5389739338991024042e5cac663bfa7a5b231474
Author: Svetoslav Neykov <sv...@cloudsoftcorp.com>
Date: 2015-11-05T20:08:00Z
Fix apache rat version
Set explicit version in the pluginManagement section to the currently use one, don't override elsewhere.
commit 1cc8aa1c0b79b2b0af6005cdb76eaeca2a9a42be
Author: Svetoslav Neykov <sv...@cloudsoftcorp.com>
Date: 2015-11-05T20:12:37Z
Disable consistently failing integration tests
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Disable consistently failing inte...
Posted by hzbarcea <gi...@git.apache.org>.
Github user hzbarcea commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1006#issuecomment-155055592
Tested, got ready to commit, @ahgittin beat me to it. We can address the osgi framework issue in a follow-up pr. Thanks @neykov.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Disable consistently failing inte...
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1006#issuecomment-155054980
some of these we really should be able to fix, but agree a "broken" category is useful to not block integration successes. we have to make sure to review broken tests before a release /cc @aledsage
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Disable consistently failing inte...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/1006
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Disable consistently failing inte...
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1006#issuecomment-154989360
@hzbarcea All the change does is use the existing `SYSTEM_BUNDLES` in `EmbeddedFelixFramework`. Currently the code is adding items to `EmbeddedFelixFramework.SYSTEM_BUNDLES` and checking for their existence in `Osgis.SYSTEM_BUNDLES` which leads to some integration tests failing.
So while the dependency is still there, at least the extension bundles will be identified correctly until your changes land.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---