You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Dmytro Sen <ds...@hortonworks.com> on 2016/04/26 10:32:30 UTC

Review Request 46683: Incorrect firewall check on CentOS7 while adding new host to cluster

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46683/
-----------------------------------------------------------

Review request for Ambari, Andrew Onischuk and Vitalyi Brodetskyi.


Bugs: AMBARI-14103
    https://issues.apache.org/jira/browse/AMBARI-14103


Repository: ambari


Description
-------

Steps: 
1. Identify a new CentOS7 host to be added to an existing HDP cluster 
2. Turn on firewall on the host as follows: 
yum install -y iptables 
yum install -y iptables-services 
service iptables start
3. From Ambari UI, go to hosts page - Actions - Add New Hosts 
4. Specify hostname and key to connect to the host; hit Next 
5. Open Host Checks screen by clicking the hyperlink to see the warnings
Result: 
"There were no firewalls running" 
Firewall issues (0)
Expected Result: 
Message should display that firewall is running
See attached - Output of iptables related commands from the console of the
CentOS7 host


Diffs
-----

  ambari-common/src/main/python/ambari_commons/firewall.py e077799 
  ambari-server/src/test/python/TestAmbariServer.py e96a7bd 

Diff: https://reviews.apache.org/r/46683/diff/


Testing
-------

Unit tests passed


Thanks,

Dmytro Sen


Re: Review Request 46683: Incorrect firewall check on CentOS7 while adding new host to cluster

Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46683/#review130568
-----------------------------------------------------------


Ship it!




Ship It!

- Andrew Onischuk


On April 26, 2016, 8:32 a.m., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46683/
> -----------------------------------------------------------
> 
> (Updated April 26, 2016, 8:32 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-14103
>     https://issues.apache.org/jira/browse/AMBARI-14103
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Steps: 
> 1. Identify a new CentOS7 host to be added to an existing HDP cluster 
> 2. Turn on firewall on the host as follows: 
> yum install -y iptables 
> yum install -y iptables-services 
> service iptables start
> 3. From Ambari UI, go to hosts page - Actions - Add New Hosts 
> 4. Specify hostname and key to connect to the host; hit Next 
> 5. Open Host Checks screen by clicking the hyperlink to see the warnings
> Result: 
> "There were no firewalls running" 
> Firewall issues (0)
> Expected Result: 
> Message should display that firewall is running
> See attached - Output of iptables related commands from the console of the
> CentOS7 host
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/ambari_commons/firewall.py e077799 
>   ambari-server/src/test/python/TestAmbariServer.py e96a7bd 
> 
> Diff: https://reviews.apache.org/r/46683/diff/
> 
> 
> Testing
> -------
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>