Re: [PR] Moves split recovery code to upgrade [accumulo]

["keith-turner (via GitHub)" <gi...@apache.org>]

keith-turner commented on code in PR #4136:
URL: https://github.com/apache/accumulo/pull/4136#discussion_r1445080166


##########
server/manager/src/main/java/org/apache/accumulo/manager/upgrade/Upgrader12to13.java:
##########
@@ -120,6 +125,7 @@ private void removeCompactColumnsFromRootTabletMetadata(ServerContext context) {
           Preconditions.checkState(key.getColumnVisibilityData().length() == 0,
               "Expected empty visibility, saw %s ", key.getColumnVisibilityData());
           Mutation m = new Mutation(row);
+          // TODO will metadata contraint fail when this is written?

Review Comment:
   @EdColeman this write may fail because the metadata constraint does not know about this column. Did the testing you did for these changes write this to the actual metadata table?
   
   I ran into this with other columns while testing these changes.  Was thinking of removing this TODO and opening an issue.  



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org