[GitHub] spark pull request #17091: [SPARK-19757][CORE] DriverEndpoint#makeOffers rac...

[vanzin <gi...@git.apache.org>]

Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17091#discussion_r104563240
  
    --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
    @@ -1646,7 +1646,7 @@ class SparkContext(config: SparkConf) extends Logging {
       def killExecutors(executorIds: Seq[String]): Boolean = {
         schedulerBackend match {
           case b: CoarseGrainedSchedulerBackend =>
    -        b.killExecutors(executorIds, replace = false, force = true).nonEmpty
    +        b.killExecutors(executorIds, replace = false, force = false).nonEmpty
    --- End diff --
    
    I don't think this should change. This is the user's code explicitly asking for executors to be killed, so there's no reason to not honor that request. It would also change the behavior of a public API, and there's no way for the user to know which executors were killed or not from the method's return value.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org