[GitHub] [pulsar] codelipenghui commented on a diff in pull request #20472: [improve][broker] Add metric prefix for `topic_load_times`

["codelipenghui (via GitHub)" <gi...@apache.org>]

codelipenghui commented on code in PR #20472:
URL: https://github.com/apache/pulsar/pull/20472#discussion_r1213953248


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/stats/BrokerOperabilityMetrics.java:
##########
@@ -84,7 +84,7 @@ Map<String, String> getDimensionMap(String metricsName) {
     }
 
     Metrics getTopicLoadMetrics() {
-        return getDimensionMetrics("topic_load_times", "topic_load", topicLoadStats);
+        return getDimensionMetrics("brk_topic_load_times", "topic_load", topicLoadStats);

Review Comment:
   @Technoboy- Will it break the existing metrics system? As we discussed before, all the metrics changes should be started with a proposal since it might surprise the pulsar operators, and impact the alert system, and metrics system.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org