[GitHub] [spark] viirya commented on a diff in pull request #37761: [SPARK-40311][SQL][CORE][PYTHON] Add withColumnsRenamed to scala and pyspark API

[GitBox <gi...@apache.org>]

viirya commented on code in PR #37761:
URL: https://github.com/apache/spark/pull/37761#discussion_r963309686


##########
python/pyspark/sql/dataframe.py:
##########
@@ -4430,6 +4430,48 @@ def withColumnRenamed(self, existing: str, new: str) -> "DataFrame":
         """
         return DataFrame(self._jdf.withColumnRenamed(existing, new), self.sparkSession)
 
+    def withColumnsRenamed(self, *colsMap: Dict[str, Column]) -> "DataFrame":

Review Comment:
   Why it is a map of str and Column? Based on `withColumnRenamed`, I think it should be a map of str and str?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org