You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by vksee <gi...@git.apache.org> on 2015/08/29 03:54:34 UTC
[GitHub] cordova-android pull request: CB-9577 Quoted specific device name ...
GitHub user vksee opened a pull request:
https://github.com/apache/cordova-android/pull/210
CB-9577 Quoted specific device name for ADB
This fixes [CB-9577](https://issues.apache.org/jira/browse/CB-9577).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vksee/cordova-android master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-android/pull/210.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #210
----
commit 2108ac8014b598771e30a5f0e48480ee1331a56d
Author: VINT <vk...@gmail.com>
Date: 2015-08-29T01:46:59Z
CB-9577 Quoted specific device name for ADB
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android pull request: CB-9577 Quoted specific device name ...
Posted by vladimir-kotikov <gi...@git.apache.org>.
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-android/pull/210#issuecomment-149873722
@nikhilkh, yes, `superspawn` module handles arguments with spaces correctly. I can't test it on real device, but tested using some mocks, and it works.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android pull request: CB-9577 Quoted specific device name ...
Posted by vksee <gi...@git.apache.org>.
Github user vksee closed the pull request at:
https://github.com/apache/cordova-android/pull/210
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android pull request: CB-9577 Quoted specific device name ...
Posted by nikhilkh <gi...@git.apache.org>.
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-android/pull/210#issuecomment-149642249
@vladimir-kotikov Looks like your refactor made this PR irrevelant. Does your new code handle this correctly?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org