You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@knox.apache.org by GitBox <gi...@apache.org> on 2020/03/17 19:30:16 UTC
[GitHub] [knox] smolnar82 opened a new pull request #290: KNOX-2296 -
Passing down the service URL field when building up a service model
smolnar82 opened a new pull request #290: KNOX-2296 - Passing down the service URL field when building up a service model
URL: https://github.com/apache/knox/pull/290
## What changes were proposed in this pull request?
Returning a `Set` of service models instead of a `List` for both UI and API services. This results in displaying only one service logo/URL with multiple service URLs in case the service URLs do not contain service-specific host/port parts.
## How was this patch tested?
Manually tested:
- added a topology (`cdp-proxy`) with IMPALA and IMPALAUI services
- both services had 2 service URLs defined
- redeployed Knox and confirmed the following using the Metadata API:
- Impala UI logo appeared twice pointing to two different instances as the service URL of IMPALA UI contains `{{HOST}}` and `{{PORT}}` placeholders
- Impala API link appeared only once
<img width="1668" alt="Screen Shot 2020-03-17 at 8 24 05 PM" src="https://user-images.githubusercontent.com/34065904/76894201-fba82680-688d-11ea-86dd-39b7fc1f8629.png">
<img width="1672" alt="Screen Shot 2020-03-17 at 8 27 03 PM" src="https://user-images.githubusercontent.com/34065904/76894235-08c51580-688e-11ea-9de5-884ad09da194.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [knox] smolnar82 merged pull request #290: KNOX-2296 - Passing down
the service URL field when building up a service model
Posted by GitBox <gi...@apache.org>.
smolnar82 merged pull request #290: KNOX-2296 - Passing down the service URL field when building up a service model
URL: https://github.com/apache/knox/pull/290
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services