[james-project] 02/32: [Refactoring] StatusProcessor: Avoid variable reallocation

[bt...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

btellier pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/james-project.git

commit bb31c7647eb649a1e5be6f63a4230c4401bf7c4d
Author: Benoit Tellier <bt...@linagora.com>
AuthorDate: Wed Nov 13 11:19:18 2019 +0700

    [Refactoring] StatusProcessor: Avoid variable reallocation
---
 .../james/imap/processor/StatusProcessor.java      | 36 ++++++++--------------
 1 file changed, 12 insertions(+), 24 deletions(-)

diff --git a/protocols/imap/src/main/java/org/apache/james/imap/processor/StatusProcessor.java b/protocols/imap/src/main/java/org/apache/james/imap/processor/StatusProcessor.java
index d761d57..5355051 100644
--- a/protocols/imap/src/main/java/org/apache/james/imap/processor/StatusProcessor.java
+++ b/protocols/imap/src/main/java/org/apache/james/imap/processor/StatusProcessor.java
@@ -93,65 +93,53 @@ public class StatusProcessor extends AbstractMailboxProcessor<StatusRequest> {
     }
 
     private Long unseen(StatusDataItems statusDataItems, MessageManager.MetaData metaData) throws MailboxException {
-        final Long unseen;
         if (statusDataItems.isUnseen()) {
-            unseen = metaData.getUnseenCount();
+            return metaData.getUnseenCount();
         } else {
-            unseen = null;
+            return null;
         }
-        return unseen;
     }
 
     private Long uidValidity(StatusDataItems statusDataItems, MessageManager.MetaData metaData) throws MailboxException {
-        final Long uidValidity;
         if (statusDataItems.isUidValidity()) {
-            uidValidity = metaData.getUidValidity();
+            return metaData.getUidValidity();
         } else {
-            uidValidity = null;
+            return null;
         }
-        return uidValidity;
     }
 
 
     private Long highestModSeq(StatusDataItems statusDataItems, MessageManager.MetaData metaData) throws MailboxException {
-        final Long highestModSeq;
         if (statusDataItems.isHighestModSeq()) {
-            highestModSeq = metaData.getHighestModSeq();
+            return metaData.getHighestModSeq();
         } else {
-            highestModSeq = null;
+            return null;
         }
-        return highestModSeq;
     }
 
     
     private MessageUid uidNext(StatusDataItems statusDataItems, MessageManager.MetaData metaData) throws MailboxException {
-        final MessageUid uidNext;
         if (statusDataItems.isUidNext()) {
-            uidNext = metaData.getUidNext();
+            return metaData.getUidNext();
         } else {
-            uidNext = null;
+            return null;
         }
-        return uidNext;
     }
 
     private Long recent(StatusDataItems statusDataItems, MessageManager.MetaData metaData) throws MailboxException {
-        final Long recent;
         if (statusDataItems.isRecent()) {
-            recent = metaData.countRecent();
+            return metaData.countRecent();
         } else {
-            recent = null;
+            return null;
         }
-        return recent;
     }
 
     private Long messages(StatusDataItems statusDataItems, MessageManager.MetaData metaData) throws MailboxException {
-        final Long messages;
         if (statusDataItems.isMessages()) {
-            messages = metaData.getMessageCount();
+           return metaData.getMessageCount();
         } else {
-            messages = null;
+            return null;
         }
-        return messages;
     }
 
     @Override


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org