You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/03/11 02:55:04 UTC

[GitHub] [spark] jackylee-ch commented on pull request #35669: [SPARK-38041][SQL] DataFilter pushed down with PartitionFilter

jackylee-ch commented on pull request #35669:
URL: https://github.com/apache/spark/pull/35669#issuecomment-1064721359


   > The data filters are actually [((id#9L > 0) OR (id#9L = 2))] and the predicate pushed down to Parquet is [((id#9L > 0) OR (id#9L = 2))]
   
   Hm, acutally, the predicate pushed down to Parquet should be `[(id#9L > 0)]` or `[(id#9L = 2)]`, that's why we need runtime filter pruning.
   BTW, it's the meaning of the pushed filter changed. In this PR, the pushed filter means the filter of push to runtime, not the filter of push to parquet. Maybe using `PushedRuntimeFilters` instande of `PushedFilters`?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org