You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@sentry.apache.org by Sergio Pena via Review Board <no...@reviews.apache.org> on 2018/09/06 14:57:13 UTC

Review Request 68657: SENTRY-2392: Add metrics statistics to list_user_privileges and list_role_privileges API

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68657/
-----------------------------------------------------------

Review request for sentry, Arjun Mishra, kalyan kumar kalvagadda, and Na Li.


Bugs: sentry-2392
    https://issues.apache.org/jira/browse/sentry-2392


Repository: sentry


Description
-------

Add some metric statistics to the new SentryPolicyStoreProcessor API that returns a list of users and roles privileges. This would be good to collect in order to understand how this API is used.


Diffs
-----

  sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryMetrics.java 35c7d079be3de8d0cf7e8067d4b5ef46c10f8d72 
  sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java 008a48efc0b1a2a8703a301c85cf0068dd171f38 


Diff: https://reviews.apache.org/r/68657/diff/1/


Testing
-------


Thanks,

Sergio Pena

Re: Review Request 68657: SENTRY-2392: Add metrics statistics to list_user_privileges and list_role_privileges API

Posted by Sergio Pena via Review Board <no...@reviews.apache.org>.


> On Sept. 6, 2018, 5:56 p.m., Steve Moist wrote:
> > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java
> > Line 1397 (original), 1397 (patched)
> > <https://reviews.apache.org/r/68657/diff/1/?file=2086188#file2086188line1397>
> >
> >     Shouldn't there be a finally block here to stop the timer?

It is using try-with-resources which closes the object inside the try() sentence.


- Sergio


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68657/#review208414
-----------------------------------------------------------


On Sept. 6, 2018, 2:57 p.m., Sergio Pena wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68657/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2018, 2:57 p.m.)
> 
> 
> Review request for sentry, Arjun Mishra, kalyan kumar kalvagadda, and Na Li.
> 
> 
> Bugs: sentry-2392
>     https://issues.apache.org/jira/browse/sentry-2392
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> Add some metric statistics to the new SentryPolicyStoreProcessor API that returns a list of users and roles privileges. This would be good to collect in order to understand how this API is used.
> 
> 
> Diffs
> -----
> 
>   sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryMetrics.java 35c7d079be3de8d0cf7e8067d4b5ef46c10f8d72 
>   sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java 008a48efc0b1a2a8703a301c85cf0068dd171f38 
> 
> 
> Diff: https://reviews.apache.org/r/68657/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergio Pena
> 
>

Re: Review Request 68657: SENTRY-2392: Add metrics statistics to list_user_privileges and list_role_privileges API

Posted by Steve Moist via Review Board <no...@reviews.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68657/#review208414
-----------------------------------------------------------




sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java
Line 1397 (original), 1397 (patched)
<https://reviews.apache.org/r/68657/#comment292319>

    Shouldn't there be a finally block here to stop the timer?


- Steve Moist


On Sept. 6, 2018, 2:57 p.m., Sergio Pena wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68657/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2018, 2:57 p.m.)
> 
> 
> Review request for sentry, Arjun Mishra, kalyan kumar kalvagadda, and Na Li.
> 
> 
> Bugs: sentry-2392
>     https://issues.apache.org/jira/browse/sentry-2392
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> Add some metric statistics to the new SentryPolicyStoreProcessor API that returns a list of users and roles privileges. This would be good to collect in order to understand how this API is used.
> 
> 
> Diffs
> -----
> 
>   sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryMetrics.java 35c7d079be3de8d0cf7e8067d4b5ef46c10f8d72 
>   sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java 008a48efc0b1a2a8703a301c85cf0068dd171f38 
> 
> 
> Diff: https://reviews.apache.org/r/68657/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergio Pena
> 
>

Re: Review Request 68657: SENTRY-2392: Add metrics statistics to list_user_privileges and list_role_privileges API

Posted by Na Li via Review Board <no...@reviews.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68657/#review208409
-----------------------------------------------------------


Ship it!




Ship It!

- Na Li


On Sept. 6, 2018, 2:57 p.m., Sergio Pena wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68657/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2018, 2:57 p.m.)
> 
> 
> Review request for sentry, Arjun Mishra, kalyan kumar kalvagadda, and Na Li.
> 
> 
> Bugs: sentry-2392
>     https://issues.apache.org/jira/browse/sentry-2392
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> Add some metric statistics to the new SentryPolicyStoreProcessor API that returns a list of users and roles privileges. This would be good to collect in order to understand how this API is used.
> 
> 
> Diffs
> -----
> 
>   sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryMetrics.java 35c7d079be3de8d0cf7e8067d4b5ef46c10f8d72 
>   sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryPolicyStoreProcessor.java 008a48efc0b1a2a8703a301c85cf0068dd171f38 
> 
> 
> Diff: https://reviews.apache.org/r/68657/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergio Pena
> 
>