You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/09/17 19:27:51 UTC

[GitHub] [kafka] abbccdda commented on a change in pull request #8295: KAFKA-9627: Replace ListOffset request/response with automated protocol

abbccdda commented on a change in pull request #8295:
URL: https://github.com/apache/kafka/pull/8295#discussion_r490504884



##########
File path: clients/src/main/resources/common/message/ListOffsetResponse.json
##########
@@ -48,7 +48,7 @@
           "about": "The timestamp associated with the returned offset." },
         { "name": "Offset", "type": "int64", "versions": "1+", "default": "-1", "ignorable": false,
           "about": "The returned offset." },
-        { "name": "LeaderEpoch", "type": "int32", "versions": "4+" }
+        { "name": "LeaderEpoch", "type": "int32", "versions": "4+", "default": "-1" }

Review comment:
       Why do we need this default?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org