[jira] [Created] (JSPWIKI-822) NPE thrown by PluginContext#getText()

["Ichiro Furusato (JIRA)" <ji...@apache.org>]

Ichiro Furusato created JSPWIKI-822:
---------------------------------------

             Summary: NPE thrown by PluginContext#getText()
                 Key: JSPWIKI-822
                 URL: https://issues.apache.org/jira/browse/JSPWIKI-822
             Project: JSPWiki
          Issue Type: Bug
          Components: Plugins
    Affects Versions: 2.10
         Environment: Ubuntu Linux 12.10, JDK 7 (but bug is independent of environment)
            Reporter: Ichiro Furusato
            Priority: Minor
             Fix For: 2.10.1


In previous versions of JSPWiki there was a null check in PluginContent#getText() to make sure that 

  WikiContext context = doc.getContext(); 

actually returns a WikiContext. In certain cases (e.g., WikiForms) the context can get lost, so that the subsequent call on line 150

  Boolean wysiwygVariable = (Boolean) context.getVariable(RenderingManager.WYSIWYG_EDITOR_MODE);

throws an NPE. I would recommend reinstating the earlier check from JSPWiki 2.9.x:

   if( context == null )
            return "No WikiContext available: INTERNAL ERROR";

or perhaps an improvement. As is, the NPE results (from the user's perspective) in empty wiki page.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)