You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Simon Zhou (JIRA)" <ji...@apache.org> on 2016/12/21 00:01:58 UTC

[jira] [Created] (CASSANDRA-13063) Too many instances of BigVersion

Simon Zhou created CASSANDRA-13063:
--------------------------------------

             Summary: Too many instances of BigVersion
                 Key: CASSANDRA-13063
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13063
             Project: Cassandra
          Issue Type: Improvement
            Reporter: Simon Zhou
            Assignee: Simon Zhou
            Priority: Minor


When debugging with Cassandra 3.0.10 I found 70+ BigVersion objects on a new node after . This was from a cluster created by CMM and had very little data. Since we create a new instance of BigVersion for each SSTable, that would create too many objects, eg, when bootstrapping new node in a cluster with many sstables.

Looks like sstables can actually share the same BigVersion instance as long as they has same version. What we can do is to create a object cache and only create new object if not found.

{code}
ConcurrentHashMap<String, BigVersion> versions = new ConcurrentHashMap<>();
{code}

May not be a big deal but a minor improvement.  [~tjake] what do you think?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)