You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by "zhuqi-lucas (via GitHub)" <gi...@apache.org> on 2023/02/14 13:58:23 UTC
[GitHub] [yunikorn-k8shim] zhuqi-lucas opened a new pull request, #531: [YUNIKORN-1549][shim] Introduce a config to specify what attribute to use as instance type.
zhuqi-lucas opened a new pull request, #531:
URL: https://github.com/apache/yunikorn-k8shim/pull/531
### What is this PR for?
We need to do the k8s related change in shim side including the specific configs.
### What type of PR is it?
* [ ] - Bug Fix
* [ ] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
* [ ] - Task
### What is the Jira issue?
* Open an issue on Jira https://issues.apache.org/jira/browse/YUNIKORN-1549
* Put link here, and add [YUNIKORN-*Jira number*] in PR title, eg. `[YUNIKORN-2] Gang scheduling interface parameters`
### How should this be tested?
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] yzhangal commented on pull request #531: [YUNIKORN-1549][shim] Introduce a config to specify what attribute to use as instance type.
Posted by "yzhangal (via GitHub)" <gi...@apache.org>.
yzhangal commented on PR #531:
URL: https://github.com/apache/yunikorn-k8shim/pull/531#issuecomment-1448885173
HI @zhuqi-lucas , thanks for your work here, there is as failure like below, would you please address it? and @wilfred-s would you please help with a review? thanks.
Ran 13 of 13 Specs in 73.166 seconds
FAIL! -- 11 Passed | 2 Failed | 0 Pending | 0 Skipped
--- FAIL: TestAdmissionController (73.17s)
FAIL
make: *** [Makefile:408: e2e_test] Error 1
Ginkgo ran 1 suite in 4m0.523696179s
Test Suite Failed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] zhuqi-lucas commented on pull request #531: [YUNIKORN-1549][shim] Introduce a config to specify what attribute to use as instance type.
Posted by "zhuqi-lucas (via GitHub)" <gi...@apache.org>.
zhuqi-lucas commented on PR #531:
URL: https://github.com/apache/yunikorn-k8shim/pull/531#issuecomment-1495328164
Sure @craigcondit , rebase it now, thanks !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] craigcondit closed pull request #531: [YUNIKORN-1549][shim] Introduce a config to specify what attribute to use as instance type.
Posted by "craigcondit (via GitHub)" <gi...@apache.org>.
craigcondit closed pull request #531: [YUNIKORN-1549][shim] Introduce a config to specify what attribute to use as instance type.
URL: https://github.com/apache/yunikorn-k8shim/pull/531
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] craigcondit commented on pull request #531: [YUNIKORN-1549][shim] Introduce a config to specify what attribute to use as instance type.
Posted by "craigcondit (via GitHub)" <gi...@apache.org>.
craigcondit commented on PR #531:
URL: https://github.com/apache/yunikorn-k8shim/pull/531#issuecomment-1494789089
@zhuqi-lucas can you rebase this on master and resubmit?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] codecov[bot] commented on pull request #531: [YUNIKORN-1549][shim] Introduce a config to specify what attribute to use as instance type.
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #531:
URL: https://github.com/apache/yunikorn-k8shim/pull/531#issuecomment-1429808874
# [Codecov](https://codecov.io/gh/apache/yunikorn-k8shim/pull/531?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#531](https://codecov.io/gh/apache/yunikorn-k8shim/pull/531?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (86bfc8b) into [master](https://codecov.io/gh/apache/yunikorn-k8shim/commit/22a00a1940224192c1386d80933a477c5691939d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (22a00a1) will **increase** coverage by `0.01%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #531 +/- ##
==========================================
+ Coverage 69.55% 69.57% +0.01%
==========================================
Files 45 45
Lines 7715 7720 +5
==========================================
+ Hits 5366 5371 +5
Misses 2153 2153
Partials 196 196
```
| [Impacted Files](https://codecov.io/gh/apache/yunikorn-k8shim/pull/531?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/common/si\_helper.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/531?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9zaV9oZWxwZXIuZ28=) | `97.63% <100.00%> (+0.02%)` | :arrow_up: |
| [pkg/conf/schedulerconf.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/531?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbmYvc2NoZWR1bGVyY29uZi5nbw==) | `81.25% <100.00%> (+0.20%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org