[GitHub] [incubator-pekko] raboof commented on issue #132: Publish artifacts using JDK 1.8 or remove sbt JDK 1.8 check?

["raboof (via GitHub)" <gi...@apache.org>]

raboof commented on issue #132:
URL: https://github.com/apache/incubator-pekko/issues/132#issuecomment-1419096096

   :wave: it was good to meet in person!
   
   I would definitely recommend compiling with JDK11 or later, to unlock some things related to `java.util.concurrent` and JFR, even if for 'the rest' of the artifacts we support running on Java 8.
   
   Indeed normally you'd just build with JDK11 and target Java 8, but because of some JVM standard library changes, for some classes (notably `EnvelopeBuffer`) this isn't sufficient, and you need to provide a reference to the JDK8 runtime library. Additionally, I think some of the `sun.misc.Unsafe` usage should still be removed before this is possible.
   
   So best in the short run would be to build with JDK11, but have JDK8 available on the build machine as well. I think on most systems this should be auto-detected (and throw an error when it is not found, in which case you can point a `JAVA_8_HOME` environment variable to it).
   
   More details at https://github.com/apache/incubator-pekko/blob/main/project/JdkOptions.scala#L60-L67 and https://github.com/apache/incubator-pekko/blob/main/project/JdkOptions.scala#L77-L79.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org