You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Chesnay Schepler (JIRA)" <ji...@apache.org> on 2018/07/31 09:22:00 UTC
[jira] [Closed] (FLINK-9987) Rework ClassLoader E2E test to not
rely on .version.properties file
[ https://issues.apache.org/jira/browse/FLINK-9987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chesnay Schepler closed FLINK-9987.
-----------------------------------
Resolution: Fixed
Fix Version/s: 1.5.3
master: a9d556e69b4ca857fc70e62e4268df5fb7a3eb2a
1.6: 7fd983e3e6e65c537cc96a22bf8f36ffd4614034
1.5: 98cb11c1b20d7f217c412db710f508964cd13538
> Rework ClassLoader E2E test to not rely on .version.properties file
> -------------------------------------------------------------------
>
> Key: FLINK-9987
> URL: https://issues.apache.org/jira/browse/FLINK-9987
> Project: Flink
> Issue Type: Improvement
> Components: Tests
> Affects Versions: 1.5.0, 1.6.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.5.3, 1.6.0
>
>
> The classloading end-to-end test makes use of the {{.version.properties}} file that is bundled with flink-runtime to ensure classloading works properly.
> In particular it access the {{git.remote.origin.url}} property.
> This should be changed since this property isn't stable across builds, which results in test failures when running the e2e tests against a release that was built on a different machine.
> The test furthermore relies on this file also existing in the source flink-runtime module, which is a dangerous assumption as this requires flink-runtime to be built beforehand. It is also _yet another_ instance where we navigate out of a module which should never be done.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)