You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/02/15 13:46:08 UTC
[GitHub] [incubator-nuttx] patacongo opened a new pull request #286:
drivers/*/Kconfig: Consolidate driver Kconfig Files.
patacongo opened a new pull request #286: drivers/*/Kconfig: Consolidate driver Kconfig Files.
URL: https://github.com/apache/incubator-nuttx/pull/286
This commit does two things:
1. First, it reorganizes the driver Kconfig files so that each is self contained. Before, a part of the driver configuration was in drivers/Kconfig and the rest was in in drivers/xyz/Konfig. Now, all of the driver configuration is consolitated in the latter.
2. Second, this commit correct numerous serious errors introduced in a previous reorganization of the driver Kconfig files. This was first noted by Nicholas Chin in PR270 for the case of the drivers/i2c/Kconfig but some examination indicates that the error was introduced into several other Kconfig files as well.
The nature of the introduced error was basically this:
- Nothing must intervene between the menuconfig selection and the following conditional configuration otpions.
- A previous PR erroneously introduced unconditional options between the menuconfig and the following confditional logic, thus corrupting the driver menus.
This error was easy to make because the driver Kconfig files were not well modularized. Making them fully self-contained should eliminate this kind of error in the future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] Ouss4 merged pull request #286:
drivers/*/Kconfig: Consolidate driver Kconfig Files.
Posted by GitBox <gi...@apache.org>.
Ouss4 merged pull request #286: drivers/*/Kconfig: Consolidate driver Kconfig Files.
URL: https://github.com/apache/incubator-nuttx/pull/286
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on issue #286:
drivers/*/Kconfig: Consolidate driver Kconfig Files.
Posted by GitBox <gi...@apache.org>.
patacongo commented on issue #286: drivers/*/Kconfig: Consolidate driver Kconfig Files.
URL: https://github.com/apache/incubator-nuttx/pull/286#issuecomment-586594987
@davids5 I worry about a lot of stuff that comes in. I don't think it is getting sufficient testing We need to make this operation more professional.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services