[GitHub] [flink] aljoscha commented on a change in pull request #14157: [FLINK-19969] CLI print run-application help msg

[GitBox <gi...@apache.org>]

aljoscha commented on a change in pull request #14157:
URL: https://github.com/apache/flink/pull/14157#discussion_r528574208



##########
File path: flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontendParser.java
##########
@@ -371,6 +372,18 @@ public static void printHelpForRun(Collection<CustomCommandLine> customCommandLi
 		System.out.println();
 	}
 
+	public static void printHelpForRunApplication() {
+		HelpFormatter formatter = new HelpFormatter();
+		formatter.setLeftPadding(5);
+		formatter.setWidth(80);
+
+		System.out.println("\nAction \"run-application\" runs an application in Application Mode.");
+		System.out.println("\n  Syntax: run-application -t [kubernetes-application, yarn-application] [OPTIONS] <jar-file> <arguments>");

Review comment:
       I think these would come from the description of the `-t` parameter, right?
   
   I also noticed that we're hardcoding the `foo-application` targets/executors because they are not real executors. That doesn't seem right.
   
   Maybe it was a mistake how we separated job/session/application. "Job" and "session" are executors, while "application" is a whole different mode. 🙈 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org