You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2018/04/13 18:36:59 UTC
[kudu-CR] KUDU-2406: derive filesystem block size from a temp file and not a directory
Hello Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/10063
to review the following change.
Change subject: KUDU-2406: derive filesystem block size from a temp file and not a directory
......................................................................
KUDU-2406: derive filesystem block size from a temp file and not a directory
No tests as simulating an environment where files and directories advertise
different block sizes would require a lot of boilerplate code.
Change-Id: Ia8da6849fae1138d5d514dacf0ba66da60857799
---
M src/kudu/fs/block_manager_util.cc
1 file changed, 19 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/63/10063/1
--
To view, visit http://gerrit.cloudera.org:8080/10063
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia8da6849fae1138d5d514dacf0ba66da60857799
Gerrit-Change-Number: 10063
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] KUDU-2406: derive filesystem block size from a temp file and not a directory
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10063 )
Change subject: KUDU-2406: derive filesystem block size from a temp file and not a directory
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10063
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8da6849fae1138d5d514dacf0ba66da60857799
Gerrit-Change-Number: 10063
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 13 Apr 2018 19:44:28 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2406: derive filesystem block size from a temp file and not a directory
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10063 )
Change subject: KUDU-2406: derive filesystem block size from a temp file and not a directory
......................................................................
KUDU-2406: derive filesystem block size from a temp file and not a directory
No tests as simulating an environment where files and directories advertise
different block sizes would require a lot of boilerplate code.
Change-Id: Ia8da6849fae1138d5d514dacf0ba66da60857799
Reviewed-on: http://gerrit.cloudera.org:8080/10063
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon <to...@apache.org>
---
M src/kudu/fs/block_manager_util.cc
1 file changed, 19 insertions(+), 1 deletion(-)
Approvals:
Kudu Jenkins: Verified
Todd Lipcon: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/10063
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia8da6849fae1138d5d514dacf0ba66da60857799
Gerrit-Change-Number: 10063
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>