You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/05/13 20:48:07 UTC
[GitHub] [iceberg] kbendick opened a new pull request #2592: [BUILD] Add .out folders to gitignore
kbendick opened a new pull request #2592:
URL: https://github.com/apache/iceberg/pull/2592
I have a number of `.out` folders that are getting in the way of my tab completion when I move around between different folders.
These are generated by gradle, and so I've added them to the .gitignore.
There is an existing entry, `out`, which does not catch these but is listed under the `gradle` section. I've removed it. It was added in a PR that also added some automation for the site, so I built the site locally and clicked around to se if an `out` log was generated but it was not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on a change in pull request #2592: [INFRA] Add .out folders to gitignore
Posted by GitBox <gi...@apache.org>.
kbendick commented on a change in pull request #2592:
URL: https://github.com/apache/iceberg/pull/2592#discussion_r632609988
##########
File path: .gitignore
##########
@@ -12,11 +12,11 @@ tmp/
# gradle build
.gradle
+.out/
build
dependencies.lock
**/dependencies.lock
gradle/
-out
Review comment:
We can keep the `out` entry if anybody feels strongly about it.
It stems from this rather old PR and is definitely supposed to be grouped with the `gradle build` section (as there were far fewer sections then): https://github.com/apache/iceberg/commit/c59138eadcfb4eb2558a15f73c00b54528d02e12
My git on my work computer (git version 2.30.1 (Apple Git-130)) does not ignore the out folders with this entry, but it does with the way I've updated it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue merged pull request #2592: [INFRA] Add .out folders to gitignore
Posted by GitBox <gi...@apache.org>.
rdblue merged pull request #2592:
URL: https://github.com/apache/iceberg/pull/2592
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on pull request #2592: [BUILD] Add .out folders to gitignore
Posted by GitBox <gi...@apache.org>.
kbendick commented on pull request #2592:
URL: https://github.com/apache/iceberg/pull/2592#issuecomment-840825248
cc @aokolnychyi @rdblue @RussellSpitzer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org