You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/02/26 03:27:45 UTC
[GitHub] [skywalking-swck] hanahmily opened a new pull request #1: Add OAP
Server CRDs
hanahmily opened a new pull request #1: Add OAP Server CRDs
URL: https://github.com/apache/skywalking-swck/pull/1
Tips for reviewers, we should pay attention to `oapserver_types.go` because most of the files are generated by kubebuilder.
Signed-off-by: Gao Hongtao <ha...@gmail.com>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-swck] withlin commented on a change in pull request #1:
Add OAP Server CRDs
Posted by GitBox <gi...@apache.org>.
withlin commented on a change in pull request #1: Add OAP Server CRDs
URL: https://github.com/apache/skywalking-swck/pull/1#discussion_r384263827
##########
File path: api/v1alpha1/oapserver_types.go
##########
@@ -0,0 +1,99 @@
+// Licensed to Apache Software Foundation (ASF) under one or more contributor
+// license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright
+// ownership. Apache Software Foundation (ASF) licenses this file to you under
+// the Apache License, Version 2.0 (the "License"); you may
+// not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package v1alpha1
+
+import (
+ corev1 "k8s.io/api/core/v1"
+ metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+)
+
+// OAPServerSpec defines the desired state of OAPServer
+type OAPServerSpec struct {
+ // Version of OAP.
+ Version string `json:"version"`
Review comment:
What do you think of using `Template corev1.PodTemplateSpec `json:" template "` `?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-swck] hanahmily commented on a change in pull request
#1: Add OAP Server CRDs
Posted by GitBox <gi...@apache.org>.
hanahmily commented on a change in pull request #1: Add OAP Server CRDs
URL: https://github.com/apache/skywalking-swck/pull/1#discussion_r384268912
##########
File path: api/v1alpha1/oapserver_types.go
##########
@@ -0,0 +1,99 @@
+// Licensed to Apache Software Foundation (ASF) under one or more contributor
+// license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright
+// ownership. Apache Software Foundation (ASF) licenses this file to you under
+// the Apache License, Version 2.0 (the "License"); you may
+// not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package v1alpha1
+
+import (
+ corev1 "k8s.io/api/core/v1"
+ metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+)
+
+// OAPServerSpec defines the desired state of OAPServer
+type OAPServerSpec struct {
+ // Version of OAP.
+ Version string `json:"version"`
Review comment:
It makes much sense to me. If we use PodTemplateSpec, fields following `Config`(NodeSelector, Affinity....) can be merged into it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-swck] hanahmily commented on a change in pull request
#1: Add OAP Server CRDs
Posted by GitBox <gi...@apache.org>.
hanahmily commented on a change in pull request #1: Add OAP Server CRDs
URL: https://github.com/apache/skywalking-swck/pull/1#discussion_r384909013
##########
File path: api/v1alpha1/oapserver_types.go
##########
@@ -0,0 +1,86 @@
+// Licensed to Apache Software Foundation (ASF) under one or more contributor
+// license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright
+// ownership. Apache Software Foundation (ASF) licenses this file to you under
+// the Apache License, Version 2.0 (the "License"); you may
+// not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package v1alpha1
+
+import (
+ corev1 "k8s.io/api/core/v1"
+ metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+)
+
+// OAPServerSpec defines the desired state of OAPServer
+type OAPServerSpec struct {
+ // Version of OAP.
+ Version string `json:"version"`
+ // Image is the OAP Server Docker image to deploy.
+ Image string `json:"image,omitempty"`
+ // Count is the number of OAP servers
+ Instances int `json:"instances,imitempty"`
Review comment:
I don't think it's a common option for the user, if they want it, `podTemplate` is a good choice for them to set up `restartPolicy` and `backoffLimit`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-swck] withlin commented on a change in pull request #1:
Add OAP Server CRDs
Posted by GitBox <gi...@apache.org>.
withlin commented on a change in pull request #1: Add OAP Server CRDs
URL: https://github.com/apache/skywalking-swck/pull/1#discussion_r384263827
##########
File path: api/v1alpha1/oapserver_types.go
##########
@@ -0,0 +1,99 @@
+// Licensed to Apache Software Foundation (ASF) under one or more contributor
+// license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright
+// ownership. Apache Software Foundation (ASF) licenses this file to you under
+// the Apache License, Version 2.0 (the "License"); you may
+// not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package v1alpha1
+
+import (
+ corev1 "k8s.io/api/core/v1"
+ metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+)
+
+// OAPServerSpec defines the desired state of OAPServer
+type OAPServerSpec struct {
+ // Version of OAP.
+ Version string `json:"version"`
Review comment:
What do you think of using `Template corev1.PodTemplateSpec `json:" template "` `?
[podspec](https://github.com/kubernetes/kubernetes/blob/master/pkg/apis/core/types.go#L2630)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-swck] wayilau commented on a change in pull request #1:
Add OAP Server CRDs
Posted by GitBox <gi...@apache.org>.
wayilau commented on a change in pull request #1: Add OAP Server CRDs
URL: https://github.com/apache/skywalking-swck/pull/1#discussion_r384305459
##########
File path: api/v1alpha1/oapserver_types.go
##########
@@ -0,0 +1,86 @@
+// Licensed to Apache Software Foundation (ASF) under one or more contributor
+// license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright
+// ownership. Apache Software Foundation (ASF) licenses this file to you under
+// the Apache License, Version 2.0 (the "License"); you may
+// not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package v1alpha1
+
+import (
+ corev1 "k8s.io/api/core/v1"
+ metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+)
+
+// OAPServerSpec defines the desired state of OAPServer
+type OAPServerSpec struct {
+ // Version of OAP.
+ Version string `json:"version"`
+ // Image is the OAP Server Docker image to deploy.
+ Image string `json:"image,omitempty"`
+ // Count is the number of OAP servers
+ Instances int `json:"instances,imitempty"`
Review comment:
We need add failedlimits for our oap instances. then choose the releated policy when limits reached. I think.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-swck] hanahmily merged pull request #1: Add OAP Server
CRDs
Posted by GitBox <gi...@apache.org>.
hanahmily merged pull request #1: Add OAP Server CRDs
URL: https://github.com/apache/skywalking-swck/pull/1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services