You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2014/09/02 23:26:19 UTC
Re: Review Request 24752: combine finalization_wait when combining
tasks
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24752/#review52088
-----------------------------------------------------------
Ping, Brian?
- Bill Farner
On Aug. 28, 2014, 3:27 p.m., Matthew Jeffryes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24752/
> -----------------------------------------------------------
>
> (Updated Aug. 28, 2014, 3:27 p.m.)
>
>
> Review request for Aurora, Bill Farner and Brian Wickman.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Problem: combine_task and concat_task helpers lose the finalization_wait information from all but the first task
> Resolution: use sum/max of finialization_wait values in concat_task/combine_task
>
>
> Diffs
> -----
>
> src/main/python/apache/thermos/config/schema_helpers.py 3feef02
> src/test/python/apache/thermos/config/test_schema.py 85b04c0
>
> Diff: https://reviews.apache.org/r/24752/diff/
>
>
> Testing
> -------
>
> ./pants src/test/python:all -vxs
>
>
> Thanks,
>
> Matthew Jeffryes
>
>