You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by ba...@apache.org on 2006/06/05 21:37:20 UTC

svn commit: r411898 - in /jakarta/commons/proper/lang/trunk/src: java/org/apache/commons/lang/StringUtils.java test/org/apache/commons/lang/StringUtilsTest.java

Author: bayard
Date: Mon Jun  5 12:37:19 2006
New Revision: 411898

URL: http://svn.apache.org/viewvc?rev=411898&view=rev
Log:
Fixing Javadoc and adding Unit Test for the example for #LANG-261. 

Modified:
    jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/StringUtils.java
    jakarta/commons/proper/lang/trunk/src/test/org/apache/commons/lang/StringUtilsTest.java

Modified: jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/StringUtils.java
URL: http://svn.apache.org/viewvc/jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/StringUtils.java?rev=411898&r1=411897&r2=411898&view=diff
==============================================================================
--- jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/StringUtils.java (original)
+++ jakarta/commons/proper/lang/trunk/src/java/org/apache/commons/lang/StringUtils.java Mon Jun  5 12:37:19 2006
@@ -2197,7 +2197,7 @@
      * StringUtils.splitPreserveAllTokens(null, *)         = null
      * StringUtils.splitPreserveAllTokens("", *)           = []
      * StringUtils.splitPreserveAllTokens("a.b.c", '.')    = ["a", "b", "c"]
-     * StringUtils.splitPreserveAllTokens("a..b.c", '.')   = ["a", "b", "c"]
+     * StringUtils.splitPreserveAllTokens("a..b.c", '.')   = ["a", "", "b", "c"]
      * StringUtils.splitPreserveAllTokens("a:b:c", '.')    = ["a:b:c"]
      * StringUtils.splitPreserveAllTokens("a\tb\nc", null) = ["a", "b", "c"]
      * StringUtils.splitPreserveAllTokens("a b c", ' ')    = ["a", "b", "c"]

Modified: jakarta/commons/proper/lang/trunk/src/test/org/apache/commons/lang/StringUtilsTest.java
URL: http://svn.apache.org/viewvc/jakarta/commons/proper/lang/trunk/src/test/org/apache/commons/lang/StringUtilsTest.java?rev=411898&r1=411897&r2=411898&view=diff
==============================================================================
--- jakarta/commons/proper/lang/trunk/src/test/org/apache/commons/lang/StringUtilsTest.java (original)
+++ jakarta/commons/proper/lang/trunk/src/test/org/apache/commons/lang/StringUtilsTest.java Mon Jun  5 12:37:19 2006
@@ -581,6 +581,16 @@
         assertEquals("b", res[3]);
         assertEquals("c", res[4]);
 
+        // Match example in javadoc
+        {
+          String[] results = null;
+          String[] expectedResults = {"a", "", "b", "c"};
+          results = StringUtils.splitPreserveAllTokens("a..b.c",'.');
+          assertEquals(expectedResults.length, results.length);
+          for (int i = 0; i < expectedResults.length; i++) {
+              assertEquals(expectedResults[i], results[i]);
+          }
+        }
     }
     
     public void testSplitPreserveAllTokens_StringString_StringStringInt() {
@@ -710,6 +720,7 @@
               assertEquals(expectedResults[i], results[i]);
           }
         }
+        
     }
     
     private void innerTestSplitPreserveAllTokens(char separator, String sepStr, char noMatch) {



---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org