You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/05/26 16:48:10 UTC

[GitHub] [kafka] cmccabe commented on a change in pull request #10752: KAFKA-12620 Allocate Producer IDs in KRaft controller

cmccabe commented on a change in pull request #10752:
URL: https://github.com/apache/kafka/pull/10752#discussion_r639919437



##########
File path: core/src/main/scala/kafka/server/BrokerServer.scala
##########
@@ -246,9 +245,16 @@ class BrokerServer(
 
       // Create transaction coordinator, but don't start it until we've started replica manager.

Review comment:
       This comment makes more sense if positioned next to the line that initializes the `transactionCoordinator`, right?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org