You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2015/11/30 19:48:45 UTC

Review Request 40788: Added lambda function in resources.cpp.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40788/
-----------------------------------------------------------

Review request for mesos, Michael Park and Neil Conway.


Repository: mesos


Description
-------

Added lambda function in resources.cpp.


Diffs
-----

  src/common/resources.cpp 98804a456b0faecc4aa56929bd1b83e5900db5ae 

Diff: https://reviews.apache.org/r/40788/diff/


Testing
-------

`make check`


Thanks,

Greg Mann


Re: Review Request 40788: Added lambda function in resources.cpp.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40788/#review108446
-----------------------------------------------------------


Patch looks great!

Reviews applied: [40788]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Nov. 30, 2015, 6:48 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40788/
> -----------------------------------------------------------
> 
> (Updated Nov. 30, 2015, 6:48 p.m.)
> 
> 
> Review request for mesos, Michael Park and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added lambda function in resources.cpp.
> 
> 
> Diffs
> -----
> 
>   src/common/resources.cpp 98804a456b0faecc4aa56929bd1b83e5900db5ae 
> 
> Diff: https://reviews.apache.org/r/40788/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Re: Review Request 40788: Added lambda function in resources.cpp.

Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40788/#review108364
-----------------------------------------------------------

Ship it!


Ship It!


src/common/resources.cpp (line 1149)
<https://reviews.apache.org/r/40788/#comment167805>

    I wonder if we could clarify this by replacing lambda::bind with a lambda expression?


- Neil Conway


On Nov. 30, 2015, 6:48 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40788/
> -----------------------------------------------------------
> 
> (Updated Nov. 30, 2015, 6:48 p.m.)
> 
> 
> Review request for mesos, Michael Park and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added lambda function in resources.cpp.
> 
> 
> Diffs
> -----
> 
>   src/common/resources.cpp 98804a456b0faecc4aa56929bd1b83e5900db5ae 
> 
> Diff: https://reviews.apache.org/r/40788/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Re: Review Request 40788: Added lambda function in resources.cpp.

Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40788/
-----------------------------------------------------------

(Updated Dec. 2, 2015, 11:19 p.m.)


Review request for mesos, Michael Park and Neil Conway.


Changes
-------

Extended changes to src/v1/resources.cpp


Repository: mesos


Description
-------

Added lambda function in resources.cpp.


Diffs (updated)
-----

  src/common/resources.cpp 0a657487c3c544068855146a39238f35ecb44f6a 
  src/v1/resources.cpp 90830c9a09aaf2c5514d9a40dbe9bf147718d132 

Diff: https://reviews.apache.org/r/40788/diff/


Testing
-------

`make check`


Thanks,

Greg Mann


Re: Review Request 40788: Added lambda function in resources.cpp.

Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40788/#review108485
-----------------------------------------------------------

Ship it!



src/common/resources.cpp 
<https://reviews.apache.org/r/40788/#comment167942>

    Could you also update the version in `src/v1/resources.cpp` please?


- Michael Park


On Nov. 30, 2015, 6:48 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40788/
> -----------------------------------------------------------
> 
> (Updated Nov. 30, 2015, 6:48 p.m.)
> 
> 
> Review request for mesos, Michael Park and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added lambda function in resources.cpp.
> 
> 
> Diffs
> -----
> 
>   src/common/resources.cpp 98804a456b0faecc4aa56929bd1b83e5900db5ae 
> 
> Diff: https://reviews.apache.org/r/40788/diff/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>