You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "roboslyq (GitHub)" <gi...@apache.org> on 2020/02/29 02:01:09 UTC
[GitHub] [dubbo] roboslyq opened pull request #5816: Merge pull
request #1 from apache/master
update 20190427 from apache master
## What is the purpose of the change
XXXXX
## Brief changelog
XXXXX
## Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] Make sure there is a [GITHUB_issue](https://github.com/apache/dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project.
- [ ] Run `mvn clean install -DskipTests=false` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass.
- [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide).
[ Full content available at: https://github.com/apache/dubbo/pull/5816 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [dubbo] codecov-io commented on issue #5816: Merge pull
request #1 from apache/master
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/5816?src=pr&el=h1) Report
> Merging [#5816](https://codecov.io/gh/apache/dubbo/pull/5816?src=pr&el=desc) into [master](https://codecov.io/gh/apache/dubbo/commit/a5827641e415adb9dc61f92217ebcc1c3234b7ee?src=pr&el=desc) will **increase** coverage by `28.78%`.
> The diff coverage is `69.28%`.
[](https://codecov.io/gh/apache/dubbo/pull/5816?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5816 +/- ##
=============================================
+ Coverage 32.46% 61.24% +28.78%
- Complexity 0 498 +498
=============================================
Files 691 981 +290
Lines 34537 39143 +4606
Branches 6812 5644 -1168
=============================================
+ Hits 11213 23975 +12762
+ Misses 21392 12536 -8856
- Partials 1932 2632 +700
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/5816?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...che/dubbo/rpc/cluster/support/FailbackCluster.java](https://codecov.io/gh/apache/dubbo/pull/5816/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvc3VwcG9ydC9GYWlsYmFja0NsdXN0ZXIuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...apache/dubbo/rpc/cluster/router/tag/model/Tag.java](https://codecov.io/gh/apache/dubbo/pull/5816/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL3RhZy9tb2RlbC9UYWcuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...er/condition/config/model/ConditionRuleParser.java](https://codecov.io/gh/apache/dubbo/pull/5816/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL2NvbmRpdGlvbi9jb25maWcvbW9kZWwvQ29uZGl0aW9uUnVsZVBhcnNlci5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...er/condition/config/model/ConditionRouterRule.java](https://codecov.io/gh/apache/dubbo/pull/5816/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL2NvbmRpdGlvbi9jb25maWcvbW9kZWwvQ29uZGl0aW9uUm91dGVyUnVsZS5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...e/dubbo/rpc/cluster/router/AbstractRouterRule.java](https://codecov.io/gh/apache/dubbo/pull/5816/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL0Fic3RyYWN0Um91dGVyUnVsZS5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...che/dubbo/rpc/cluster/support/FailsafeCluster.java](https://codecov.io/gh/apache/dubbo/pull/5816/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvc3VwcG9ydC9GYWlsc2FmZUNsdXN0ZXIuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...o/rpc/cluster/support/BroadcastClusterInvoker.java](https://codecov.io/gh/apache/dubbo/pull/5816/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvc3VwcG9ydC9Ccm9hZGNhc3RDbHVzdGVySW52b2tlci5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...he/dubbo/rpc/cluster/support/MergeableCluster.java](https://codecov.io/gh/apache/dubbo/pull/5816/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvc3VwcG9ydC9NZXJnZWFibGVDbHVzdGVyLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...bo/rpc/cluster/router/tag/model/TagRouterRule.java](https://codecov.io/gh/apache/dubbo/pull/5816/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL3RhZy9tb2RlbC9UYWdSb3V0ZXJSdWxlLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...bo/rpc/cluster/router/tag/model/TagRuleParser.java](https://codecov.io/gh/apache/dubbo/pull/5816/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL3RhZy9tb2RlbC9UYWdSdWxlUGFyc2VyLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | |
| ... and [1646 more](https://codecov.io/gh/apache/dubbo/pull/5816/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/5816?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/5816?src=pr&el=footer). Last update [a582764...fb78def](https://codecov.io/gh/apache/dubbo/pull/5816?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/dubbo/pull/5816 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org