You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by robertkowalski <gi...@git.apache.org> on 2015/03/03 13:54:29 UTC
[GitHub] couchdb-fauxton pull request: componentize the code-editor with be...
GitHub user robertkowalski opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/300
componentize the code-editor with beautfier
will reuse it for mango
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/robertkowalski/couchdb-fauxton common-comps-2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/300.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #300
----
commit c3ffd0a87f6b004f81df8041d560cb2c0b62e968
Author: Robert Kowalski <ro...@apache.org>
Date: 2015-03-03T12:50:06Z
componentize the code-editor with beautfier
will reuse it for mango
commit 0b02ab6a81571d5b749e9e953aa94d0d4a0fd46c
Author: Robert Kowalski <ro...@apache.org>
Date: 2015-03-03T12:50:55Z
cleanup: remove unused function
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: componentize the code-editor with be...
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/300
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: componentize the code-editor with be...
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/300#issuecomment-77174678
+1 looks great
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: componentize the code-editor with be...
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/300#issuecomment-76948642
This looks good. But it breaks when I try and create a new view. Also the tests are failing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: componentize the code-editor with be...
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/300#issuecomment-77176325
meregd as:
e95eec58db10c86354897f3963cf37cb2b8e96fc
18c96098b1da0a44dff93ea1dee5dfce84a6d48b
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: componentize the code-editor with be...
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/300#issuecomment-76949589
The next step is to remove the backbone view for ace editor and do it completely in React.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---