You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/03/04 21:26:58 UTC

[GitHub] [tvm] vinx13 commented on a change in pull request #7572: [Vulkan] Support passing 64 bit scalar

vinx13 commented on a change in pull request #7572:
URL: https://github.com/apache/tvm/pull/7572#discussion_r587837241



##########
File path: src/target/source/codegen_metal.cc
##########
@@ -47,7 +47,7 @@ CodeGenMetal::CodeGenMetal() {
   decl_stream << "#include <metal_stdlib>\n";
   decl_stream << "using namespace metal;\n\n";
   decl_stream << "union __TVMArgUnion {\n"
-              << " int v_int;\n"
+              << " int v_long;\n"

Review comment:
       if I add bits()==64 support explicitly (which doesn't use ArgUnion), is there any case we will use `ArgUnion`? Looks like previous this union hardcoded to only support `int`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org