You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Sowmya Krishnan <so...@citrix.com> on 2013/08/26 19:43:34 UTC
Review Request 13821: CLOUDSTACK-4510 Move NS scripts to appropriate suite
to avoid failures
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13821/
-----------------------------------------------------------
Review request for cloudstack, venkata swamy babu budumuru and Prasanna Santhanam.
Bugs: CLOUDSTACK-4510
Repository: cloudstack-git
Description
-------
Moved TestNwOffNetscaler from test_network_offerings to test_netscaler_nw_off since it's more relevant sitting in the latter.
Also, it's important that NS scripts run separately with add/remove as part of setup/tearDown since we assume that NS addition/deletion is handled completely by the script itself.
Related to this, there are some minor changes in common.py -> add_netscaler to accept NS services directly than the entire services object. Provides more flexibility this way to be able to specify which NS device should be added if we have more than one in the script.
Appropriate changes were also done to scripts using add_netscaler
Diffs
-----
test/integration/component/test_netscaler_lb.py 8375f25
test/integration/component/test_netscaler_lb_algo.py 24c1837
test/integration/component/test_netscaler_lb_sticky.py 7ec85a1
test/integration/component/test_netscaler_nw_off.py 5742f09
test/integration/component/test_network_offering.py e8a7b97
tools/marvin/marvin/integration/lib/common.py 7e8d92d
Diff: https://reviews.apache.org/r/13821/diff/
Testing
-------
Tested the scripts locally and they are all passing.
Thanks,
Sowmya Krishnan
Re: Review Request 13821: CLOUDSTACK-4510 Move NS scripts to appropriate
suite to avoid failures
Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13821/#review25596
-----------------------------------------------------------
Ship it!
thanks for the refactor. applied to master and 4.2-forward. please close the review as submitted.
- Prasanna Santhanam
On Aug. 26, 2013, 5:43 p.m., Sowmya Krishnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13821/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2013, 5:43 p.m.)
>
>
> Review request for cloudstack, venkata swamy babu budumuru and Prasanna Santhanam.
>
>
> Bugs: CLOUDSTACK-4510
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Moved TestNwOffNetscaler from test_network_offerings to test_netscaler_nw_off since it's more relevant sitting in the latter.
> Also, it's important that NS scripts run separately with add/remove as part of setup/tearDown since we assume that NS addition/deletion is handled completely by the script itself.
>
> Related to this, there are some minor changes in common.py -> add_netscaler to accept NS services directly than the entire services object. Provides more flexibility this way to be able to specify which NS device should be added if we have more than one in the script.
>
> Appropriate changes were also done to scripts using add_netscaler
>
>
> Diffs
> -----
>
> test/integration/component/test_netscaler_lb.py 8375f25
> test/integration/component/test_netscaler_lb_algo.py 24c1837
> test/integration/component/test_netscaler_lb_sticky.py 7ec85a1
> test/integration/component/test_netscaler_nw_off.py 5742f09
> test/integration/component/test_network_offering.py e8a7b97
> tools/marvin/marvin/integration/lib/common.py 7e8d92d
>
> Diff: https://reviews.apache.org/r/13821/diff/
>
>
> Testing
> -------
>
> Tested the scripts locally and they are all passing.
>
>
> Thanks,
>
> Sowmya Krishnan
>
>
Re: Review Request 13821: CLOUDSTACK-4510 Move NS scripts to appropriate
suite to avoid failures
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13821/#review25594
-----------------------------------------------------------
Commit f1c6535f6ee0e5f9b4e6a3435ad2c1dd322a8074 in branch refs/heads/master from Sowmya Krishnan
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=f1c6535 ]
CLOUDSTACK-4510 Move NS scripts to appropriate suites and related common.py fixes
Signed-off-by: Prasanna Santhanam <ts...@apache.org>
(cherry picked from commit f7df3ef9f1d6127d5438e58af7dccfbd1f58461c)
- ASF Subversion and Git Services
On Aug. 26, 2013, 5:43 p.m., Sowmya Krishnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13821/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2013, 5:43 p.m.)
>
>
> Review request for cloudstack, venkata swamy babu budumuru and Prasanna Santhanam.
>
>
> Bugs: CLOUDSTACK-4510
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Moved TestNwOffNetscaler from test_network_offerings to test_netscaler_nw_off since it's more relevant sitting in the latter.
> Also, it's important that NS scripts run separately with add/remove as part of setup/tearDown since we assume that NS addition/deletion is handled completely by the script itself.
>
> Related to this, there are some minor changes in common.py -> add_netscaler to accept NS services directly than the entire services object. Provides more flexibility this way to be able to specify which NS device should be added if we have more than one in the script.
>
> Appropriate changes were also done to scripts using add_netscaler
>
>
> Diffs
> -----
>
> test/integration/component/test_netscaler_lb.py 8375f25
> test/integration/component/test_netscaler_lb_algo.py 24c1837
> test/integration/component/test_netscaler_lb_sticky.py 7ec85a1
> test/integration/component/test_netscaler_nw_off.py 5742f09
> test/integration/component/test_network_offering.py e8a7b97
> tools/marvin/marvin/integration/lib/common.py 7e8d92d
>
> Diff: https://reviews.apache.org/r/13821/diff/
>
>
> Testing
> -------
>
> Tested the scripts locally and they are all passing.
>
>
> Thanks,
>
> Sowmya Krishnan
>
>
Re: Review Request 13821: CLOUDSTACK-4510 Move NS scripts to appropriate
suite to avoid failures
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13821/#review25595
-----------------------------------------------------------
Commit f7df3ef9f1d6127d5438e58af7dccfbd1f58461c in branch refs/heads/4.2-forward from Sowmya Krishnan
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=f7df3ef ]
CLOUDSTACK-4510 Move NS scripts to appropriate suites and related common.py fixes
Signed-off-by: Prasanna Santhanam <ts...@apache.org>
- ASF Subversion and Git Services
On Aug. 26, 2013, 5:43 p.m., Sowmya Krishnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13821/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2013, 5:43 p.m.)
>
>
> Review request for cloudstack, venkata swamy babu budumuru and Prasanna Santhanam.
>
>
> Bugs: CLOUDSTACK-4510
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Moved TestNwOffNetscaler from test_network_offerings to test_netscaler_nw_off since it's more relevant sitting in the latter.
> Also, it's important that NS scripts run separately with add/remove as part of setup/tearDown since we assume that NS addition/deletion is handled completely by the script itself.
>
> Related to this, there are some minor changes in common.py -> add_netscaler to accept NS services directly than the entire services object. Provides more flexibility this way to be able to specify which NS device should be added if we have more than one in the script.
>
> Appropriate changes were also done to scripts using add_netscaler
>
>
> Diffs
> -----
>
> test/integration/component/test_netscaler_lb.py 8375f25
> test/integration/component/test_netscaler_lb_algo.py 24c1837
> test/integration/component/test_netscaler_lb_sticky.py 7ec85a1
> test/integration/component/test_netscaler_nw_off.py 5742f09
> test/integration/component/test_network_offering.py e8a7b97
> tools/marvin/marvin/integration/lib/common.py 7e8d92d
>
> Diff: https://reviews.apache.org/r/13821/diff/
>
>
> Testing
> -------
>
> Tested the scripts locally and they are all passing.
>
>
> Thanks,
>
> Sowmya Krishnan
>
>