You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "vcrfxia (via GitHub)" <gi...@apache.org> on 2023/04/05 23:05:38 UTC

[GitHub] [kafka] vcrfxia commented on a diff in pull request #13509: KAFKA-14834: [3/N] Timestamped lookups for stream-table joins

vcrfxia commented on code in PR #13509:
URL: https://github.com/apache/kafka/pull/13509#discussion_r1159109536


##########
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamGlobalKTableJoinTest.java:
##########
@@ -246,4 +262,30 @@ public void shouldJoinOnNullKeyWithNonNullKeyMapperValues() {
         processor.checkAndClearProcessResult(new KeyValueTimestamp<>(null, "X0,FKey0+Y0", 0),
                 new KeyValueTimestamp<>(1, "X1,FKey1+Y1", 1));
     }
+
+    @Test
+    public void shouldPerformTimestampedGet() {

Review Comment:
   It doesn't look like there's existing integration test coverage for KStream-GlobalKTable joins, so I've added these tests here instead. 
   
   For KStream-KTable joins, there's also `KStreamKTableJoinTest` and `KStreamKTableLeftJoinTest` which I did not update, since I opted to update `StreamTableJoinIntegrationTest` instead. AFAICT both sets of tests are run with the TopologyTestDriver so updating `KStreamKTableJoinTest` and `KStreamKTableLeftJoinTest` would be redundant to having updated `StreamTableJoinIntegrationTest`, but if that's not true then I can update those unit tests as well.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org