You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@helix.apache.org by GitBox <gi...@apache.org> on 2019/07/31 23:21:17 UTC

[GitHub] [helix] narendly commented on a change in pull request #367: Add transient cache for CustomRestClient implementation

narendly commented on a change in pull request #367: Add transient cache for CustomRestClient implementation
URL: https://github.com/apache/helix/pull/367#discussion_r309469352
 
 

 ##########
 File path: helix-rest/src/main/java/org/apache/helix/rest/client/CustomRestClientImpl.java
 ##########
 @@ -52,16 +56,26 @@
   private static final String ACCEPT_CONTENT_TYPE = "application/json";
   private static final ObjectMapper OBJECT_MAPPER = new ObjectMapper();
 
-  private HttpClient _httpClient;
+  private final HttpClient _httpClient;
+  private final Semaphore _semaphore;
 
 Review comment:
   Could we add a block comment here on why it's necessary to have a semaphore here (just how you did for cachedResults)?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services